foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-29 16:30:56 -05:00
Code Issues Packages 1 Wiki Activity

refactor(core): don't pass op state to prepare_module_load() (#19332)

Browse source 
It's not used anymore. Subsequently allows removing
`ModuleMap::op_state`, allowing `ModuleMap` to have a sane default so
`JsRuntime::module_map` no longer needs to be optional.
This commit is contained in:
Nayeem Rahman 2023-06-01 06:35:14 +01:00 committed by Bartek Iwańczuk
parent 8f9a05f16e
commit 6836e5a6eb
No known key found for this signature in database
GPG key ID: 0C6BCDDC3B3AD750
3 changed files with 48 additions and 70 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cli/module_loader.rs
View file

@ -37,7 +37,6 @@ use deno_core::ModuleLoader;
use deno_core::ModuleSource; use deno_core::ModuleSource;
use deno_core::ModuleSpecifier; use deno_core::ModuleSpecifier;
use deno_core::ModuleType; use deno_core::ModuleType;
use deno_core::OpState;
use deno_core::ResolutionKind; use deno_core::ResolutionKind;
use deno_core::SourceMapGetter; use deno_core::SourceMapGetter;
use deno_graph::source::Resolver; use deno_graph::source::Resolver;
@ -54,7 +53,6 @@ use deno_runtime::permissions::PermissionsContainer;
use deno_semver::npm::NpmPackageNvReference; use deno_semver::npm::NpmPackageNvReference;
use deno_semver::npm::NpmPackageReqReference; use deno_semver::npm::NpmPackageReqReference;
use std::borrow::Cow; use std::borrow::Cow;
use std::cell::RefCell;
use std::collections::HashSet; use std::collections::HashSet;
use std::pin::Pin; use std::pin::Pin;
use std::rc::Rc; use std::rc::Rc;
@ -566,7 +564,6 @@ impl ModuleLoader for CliModuleLoader {
fn prepare_load( fn prepare_load(
&self, &self,
_op_state: Rc<RefCell<OpState>>,
specifier: &ModuleSpecifier, specifier: &ModuleSpecifier,
_maybe_referrer: Option<String>, _maybe_referrer: Option<String>,
is_dynamic: bool, is_dynamic: bool,

33
core/modules.rs
View file

@ -11,7 +11,6 @@ use crate::resolve_url;
use crate::snapshot_util::SnapshottedData; use crate::snapshot_util::SnapshottedData;
use crate::Extension; use crate::Extension;
use crate::JsRuntime; use crate::JsRuntime;
use crate::OpState;
use anyhow::anyhow; use anyhow::anyhow;
use anyhow::Error; use anyhow::Error;
use futures::future::FutureExt; use futures::future::FutureExt;
@ -340,7 +339,6 @@ pub trait ModuleLoader {
/// It's not required to implement this method. /// It's not required to implement this method.
fn prepare_load( fn prepare_load(
&self, &self,
_op_state: Rc<RefCell<OpState>>,
_module_specifier: &ModuleSpecifier, _module_specifier: &ModuleSpecifier,
_maybe_referrer: Option<String>, _maybe_referrer: Option<String>,
_is_dyn_import: bool, _is_dyn_import: bool,
@ -453,7 +451,6 @@ impl ModuleLoader for ExtModuleLoader {
fn prepare_load( fn prepare_load(
&self, &self,
_op_state: Rc<RefCell<OpState>>,
_specifier: &ModuleSpecifier, _specifier: &ModuleSpecifier,
_maybe_referrer: Option<String>, _maybe_referrer: Option<String>,
_is_dyn_import: bool, _is_dyn_import: bool,
@ -567,9 +564,8 @@ pub(crate) struct RecursiveModuleLoad {
module_map_rc: Rc<RefCell<ModuleMap>>, module_map_rc: Rc<RefCell<ModuleMap>>,
pending: FuturesUnordered<Pin<Box<ModuleLoadFuture>>>, pending: FuturesUnordered<Pin<Box<ModuleLoadFuture>>>,
visited: HashSet<ModuleRequest>, visited: HashSet<ModuleRequest>,
// These three fields are copied from `module_map_rc`, but they are cloned // The loader is copied from `module_map_rc`, but its reference is cloned
// ahead of time to avoid already-borrowed errors. // ahead of time to avoid already-borrowed errors.
op_state: Rc<RefCell<OpState>>,
loader: Rc<dyn ModuleLoader>, loader: Rc<dyn ModuleLoader>,
} }
@ -612,7 +608,6 @@ impl RecursiveModuleLoad {
module_map.next_load_id += 1; module_map.next_load_id += 1;
id id
}; };
let op_state = module_map_rc.borrow().op_state.clone();
let loader = module_map_rc.borrow().loader.clone(); let loader = module_map_rc.borrow().loader.clone();
let asserted_module_type = match init { let asserted_module_type = match init {
LoadInit::DynamicImport(_, _, module_type) => module_type, LoadInit::DynamicImport(_, _, module_type) => module_type,
@ -626,7 +621,6 @@ impl RecursiveModuleLoad {
init, init,
state: LoadState::Init, state: LoadState::Init,
module_map_rc: module_map_rc.clone(), module_map_rc: module_map_rc.clone(),
op_state,
loader, loader,
pending: FuturesUnordered::new(), pending: FuturesUnordered::new(),
visited: HashSet::new(), visited: HashSet::new(),
@ -669,8 +663,6 @@ impl RecursiveModuleLoad {
} }
async fn prepare(&self) -> Result<(), Error> { async fn prepare(&self) -> Result<(), Error> {
let op_state = self.op_state.clone();
let (module_specifier, maybe_referrer) = match self.init { let (module_specifier, maybe_referrer) = match self.init {
LoadInit::Main(ref specifier) => { LoadInit::Main(ref specifier) => {
let spec = let spec =
@ -698,12 +690,7 @@ impl RecursiveModuleLoad {
self self
.loader .loader
.prepare_load( .prepare_load(&module_specifier, maybe_referrer, self.is_dynamic_import())
op_state,
&module_specifier,
maybe_referrer,
self.is_dynamic_import(),
)
.await .await
} }
@ -997,7 +984,6 @@ pub(crate) struct ModuleMap {
// Handling of futures for loading module sources // Handling of futures for loading module sources
pub loader: Rc<dyn ModuleLoader>, pub loader: Rc<dyn ModuleLoader>,
op_state: Rc<RefCell<OpState>>,
pub(crate) dynamic_import_map: pub(crate) dynamic_import_map:
HashMap<ModuleLoadId, v8::Global<v8::PromiseResolver>>, HashMap<ModuleLoadId, v8::Global<v8::PromiseResolver>>,
pub(crate) preparing_dynamic_imports: pub(crate) preparing_dynamic_imports:
@ -1304,10 +1290,7 @@ impl ModuleMap {
self.handles = snapshotted_data.module_handles; self.handles = snapshotted_data.module_handles;
} }
pub(crate) fn new( pub(crate) fn new(loader: Rc<dyn ModuleLoader>) -> ModuleMap {
loader: Rc<dyn ModuleLoader>,
op_state: Rc<RefCell<OpState>>,
) -> ModuleMap {
Self { Self {
handles: vec![], handles: vec![],
info: vec![], info: vec![],
@ -1315,7 +1298,6 @@ impl ModuleMap {
by_name_json: HashMap::new(), by_name_json: HashMap::new(),
next_load_id: 1, next_load_id: 1,
loader, loader,
op_state,
dynamic_import_map: HashMap::new(), dynamic_import_map: HashMap::new(),
preparing_dynamic_imports: FuturesUnordered::new(), preparing_dynamic_imports: FuturesUnordered::new(),
pending_dynamic_imports: FuturesUnordered::new(), pending_dynamic_imports: FuturesUnordered::new(),
@ -1493,7 +1475,7 @@ impl ModuleMap {
} }
pub(crate) fn clear(&mut self) { pub(crate) fn clear(&mut self) {
*self = Self::new(self.loader.clone(), self.op_state.clone()) *self = Self::new(self.loader.clone())
} }
pub(crate) fn get_handle_by_name( pub(crate) fn get_handle_by_name(
@ -1714,6 +1696,12 @@ impl ModuleMap {
} }
} }
impl Default for ModuleMap {
fn default() -> Self {
Self::new(Rc::new(NoopModuleLoader))
}
}
#[cfg(test)] #[cfg(test)]
mod tests { mod tests {
use super::*; use super::*;
@ -2339,7 +2327,6 @@ import "/a.js";
fn prepare_load( fn prepare_load(
&self, &self,
_op_state: Rc<RefCell<OpState>>,
_module_specifier: &ModuleSpecifier, _module_specifier: &ModuleSpecifier,
_maybe_referrer: Option<String>, _maybe_referrer: Option<String>,
_is_dyn_import: bool, _is_dyn_import: bool,

82
core/runtime.rs
View file

@ -202,7 +202,7 @@ impl Drop for InnerIsolateState {
/// type aliases. /// type aliases.
pub struct JsRuntimeImpl<const FOR_SNAPSHOT: bool = false> { pub struct JsRuntimeImpl<const FOR_SNAPSHOT: bool = false> {
inner: InnerIsolateState, inner: InnerIsolateState,
module_map: Option<Rc<RefCell<ModuleMap>>>, module_map: Rc<RefCell<ModuleMap>>,
allocations: IsolateAllocations, allocations: IsolateAllocations,
extensions: Vec<Extension>, extensions: Vec<Extension>,
event_loop_middlewares: Vec<Box<OpEventLoopFn>>, event_loop_middlewares: Vec<Box<OpEventLoopFn>>,
@ -607,7 +607,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
STATE_DATA_OFFSET, STATE_DATA_OFFSET,
Rc::into_raw(state_rc.clone()) as *mut c_void, Rc::into_raw(state_rc.clone()) as *mut c_void,
); );
let module_map_rc = Rc::new(RefCell::new(ModuleMap::new(loader, op_state))); let module_map_rc = Rc::new(RefCell::new(ModuleMap::new(loader)));
if let Some(snapshotted_data) = snapshotted_data { if let Some(snapshotted_data) = snapshotted_data {
let mut module_map = module_map_rc.borrow_mut(); let mut module_map = module_map_rc.borrow_mut();
module_map.update_with_snapshotted_data(scope, snapshotted_data); module_map.update_with_snapshotted_data(scope, snapshotted_data);
@ -629,7 +629,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
allocations: IsolateAllocations::default(), allocations: IsolateAllocations::default(),
event_loop_middlewares, event_loop_middlewares,
extensions: options.extensions, extensions: options.extensions,
module_map: Some(module_map_rc), module_map: module_map_rc,
is_main: options.is_main, is_main: options.is_main,
}; };
@ -686,9 +686,10 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
(isolate, context, snapshotted_data) (isolate, context, snapshotted_data)
} }
#[cfg(test)]
#[inline] #[inline]
pub(crate) fn module_map(&self) -> &Rc<RefCell<ModuleMap>> { pub(crate) fn module_map(&self) -> &Rc<RefCell<ModuleMap>> {
self.module_map.as_ref().unwrap() &self.module_map
} }
#[inline] #[inline]
@ -807,13 +808,12 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
let extensions = std::mem::take(&mut self.extensions); let extensions = std::mem::take(&mut self.extensions);
// TODO(nayeemrmn): Module maps should be per-realm. // TODO(nayeemrmn): Module maps should be per-realm.
let module_map = self.module_map.as_ref().unwrap(); let loader = self.module_map.borrow().loader.clone();
let loader = module_map.borrow().loader.clone();
let ext_loader = Rc::new(ExtModuleLoader::new( let ext_loader = Rc::new(ExtModuleLoader::new(
&extensions, &extensions,
maybe_load_callback.map(Rc::new), maybe_load_callback.map(Rc::new),
)); ));
module_map.borrow_mut().loader = ext_loader; self.module_map.borrow_mut().loader = ext_loader;
let mut esm_entrypoints = vec![]; let mut esm_entrypoints = vec![];
@ -853,9 +853,8 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
for specifier in esm_entrypoints { for specifier in esm_entrypoints {
let mod_id = { let mod_id = {
let module_map = self.module_map.as_ref().unwrap(); self
.module_map
module_map
.borrow() .borrow()
.get_id(specifier, AssertedModuleType::JavaScriptOrWasm) .get_id(specifier, AssertedModuleType::JavaScriptOrWasm)
.unwrap_or_else(|| { .unwrap_or_else(|| {
@ -871,7 +870,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
#[cfg(debug_assertions)] #[cfg(debug_assertions)]
{ {
let module_map_rc = self.module_map.clone().unwrap(); let module_map_rc = self.module_map.clone();
let mut scope = realm.handle_scope(self.v8_isolate()); let mut scope = realm.handle_scope(self.v8_isolate());
let module_map = module_map_rc.borrow(); let module_map = module_map_rc.borrow();
module_map.assert_all_modules_evaluated(&mut scope); module_map.assert_all_modules_evaluated(&mut scope);
@ -881,7 +880,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
})?; })?;
self.extensions = extensions; self.extensions = extensions;
self.module_map.as_ref().unwrap().borrow_mut().loader = loader; self.module_map.borrow_mut().loader = loader;
Ok(()) Ok(())
} }
@ -1133,9 +1132,8 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
&mut self, &mut self,
module_id: ModuleId, module_id: ModuleId,
) -> Result<v8::Global<v8::Object>, Error> { ) -> Result<v8::Global<v8::Object>, Error> {
let module_map_rc = self.module_map(); let module_handle = self
.module_map
let module_handle = module_map_rc
.borrow() .borrow()
.get_handle(module_id) .get_handle(module_id)
.expect("ModuleInfo not found"); .expect("ModuleInfo not found");
@ -1467,7 +1465,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
EventLoopPendingState::new( EventLoopPendingState::new(
&mut scope, &mut scope,
&mut self.inner.state.borrow_mut(), &mut self.inner.state.borrow_mut(),
&self.module_map.as_ref().unwrap().borrow(), &self.module_map.borrow(),
) )
} }
} }
@ -1566,7 +1564,10 @@ impl JsRuntimeForSnapshot {
// Serialize the module map and store its data in the snapshot. // Serialize the module map and store its data in the snapshot.
{ {
let snapshotted_data = { let snapshotted_data = {
let module_map_rc = self.module_map.take().unwrap(); // `self.module_map` points directly to the v8 isolate data slot, which
// we must explicitly drop before destroying the isolate. We have to
// take and drop this `Rc` before that.
let module_map_rc = std::mem::take(&mut self.module_map);
let module_map = module_map_rc.borrow(); let module_map = module_map_rc.borrow();
module_map.serialize_for_snapshotting(&mut self.handle_scope()) module_map.serialize_for_snapshotting(&mut self.handle_scope())
}; };
@ -1804,7 +1805,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
&mut self, &mut self,
id: ModuleId, id: ModuleId,
) -> Result<(), v8::Global<v8::Value>> { ) -> Result<(), v8::Global<v8::Value>> {
let module_map_rc = self.module_map().clone(); let module_map_rc = self.module_map.clone();
let scope = &mut self.handle_scope(); let scope = &mut self.handle_scope();
let tc_scope = &mut v8::TryCatch::new(scope); let tc_scope = &mut v8::TryCatch::new(scope);
@ -1837,9 +1838,8 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
load_id: ModuleLoadId, load_id: ModuleLoadId,
id: ModuleId, id: ModuleId,
) -> Result<(), Error> { ) -> Result<(), Error> {
let module_map_rc = self.module_map(); let module_handle = self
.module_map
let module_handle = module_map_rc
.borrow() .borrow()
.get_handle(id) .get_handle(id)
.expect("ModuleInfo not found"); .expect("ModuleInfo not found");
@ -1929,7 +1929,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
) -> oneshot::Receiver<Result<(), Error>> { ) -> oneshot::Receiver<Result<(), Error>> {
let global_realm = self.global_realm(); let global_realm = self.global_realm();
let state_rc = self.inner.state.clone(); let state_rc = self.inner.state.clone();
let module_map_rc = self.module_map().clone(); let module_map_rc = self.module_map.clone();
let scope = &mut self.handle_scope(); let scope = &mut self.handle_scope();
let tc_scope = &mut v8::TryCatch::new(scope); let tc_scope = &mut v8::TryCatch::new(scope);
@ -2049,7 +2049,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
&self, &self,
exceptions: impl Iterator<Item = (&'static str, &'static str)>, exceptions: impl Iterator<Item = (&'static str, &'static str)>,
) { ) {
let mut module_map = self.module_map.as_ref().unwrap().borrow_mut(); let mut module_map = self.module_map.borrow_mut();
let handles = exceptions let handles = exceptions
.map(|(old_name, new_name)| { .map(|(old_name, new_name)| {
(module_map.get_handle_by_name(old_name).unwrap(), new_name) (module_map.get_handle_by_name(old_name).unwrap(), new_name)
@ -2070,7 +2070,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
id: ModuleLoadId, id: ModuleLoadId,
exception: v8::Global<v8::Value>, exception: v8::Global<v8::Value>,
) { ) {
let module_map_rc = self.module_map().clone(); let module_map_rc = self.module_map.clone();
let scope = &mut self.handle_scope(); let scope = &mut self.handle_scope();
let resolver_handle = module_map_rc let resolver_handle = module_map_rc
@ -2091,7 +2091,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
fn dynamic_import_resolve(&mut self, id: ModuleLoadId, mod_id: ModuleId) { fn dynamic_import_resolve(&mut self, id: ModuleLoadId, mod_id: ModuleId) {
let state_rc = self.inner.state.clone(); let state_rc = self.inner.state.clone();
let module_map_rc = self.module_map().clone(); let module_map_rc = self.module_map.clone();
let scope = &mut self.handle_scope(); let scope = &mut self.handle_scope();
let resolver_handle = module_map_rc let resolver_handle = module_map_rc
@ -2126,7 +2126,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
cx: &mut Context, cx: &mut Context,
) -> Poll<Result<(), Error>> { ) -> Poll<Result<(), Error>> {
if self if self
.module_map() .module_map
.borrow() .borrow()
.preparing_dynamic_imports .preparing_dynamic_imports
.is_empty() .is_empty()
@ -2134,10 +2134,9 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
return Poll::Ready(Ok(())); return Poll::Ready(Ok(()));
} }
let module_map_rc = self.module_map().clone();
loop { loop {
let poll_result = module_map_rc let poll_result = self
.module_map
.borrow_mut() .borrow_mut()
.preparing_dynamic_imports .preparing_dynamic_imports
.poll_next_unpin(cx); .poll_next_unpin(cx);
@ -2148,7 +2147,8 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
match prepare_result { match prepare_result {
Ok(load) => { Ok(load) => {
module_map_rc self
.module_map
.borrow_mut() .borrow_mut()
.pending_dynamic_imports .pending_dynamic_imports
.push(load.into_future()); .push(load.into_future());
@ -2168,19 +2168,13 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
} }
fn poll_dyn_imports(&mut self, cx: &mut Context) -> Poll<Result<(), Error>> { fn poll_dyn_imports(&mut self, cx: &mut Context) -> Poll<Result<(), Error>> {
if self if self.module_map.borrow().pending_dynamic_imports.is_empty() {
.module_map()
.borrow()
.pending_dynamic_imports
.is_empty()
{
return Poll::Ready(Ok(())); return Poll::Ready(Ok(()));
} }
let module_map_rc = self.module_map().clone();
loop { loop {
let poll_result = module_map_rc let poll_result = self
.module_map
.borrow_mut() .borrow_mut()
.pending_dynamic_imports .pending_dynamic_imports
.poll_next_unpin(cx); .poll_next_unpin(cx);
@ -2205,7 +2199,8 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
match register_result { match register_result {
Ok(()) => { Ok(()) => {
// Keep importing until it's fully drained // Keep importing until it's fully drained
module_map_rc self
.module_map
.borrow_mut() .borrow_mut()
.pending_dynamic_imports .pending_dynamic_imports
.push(load.into_future()); .push(load.into_future());
@ -2374,7 +2369,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
specifier: &ModuleSpecifier, specifier: &ModuleSpecifier,
code: Option<ModuleCode>, code: Option<ModuleCode>,
) -> Result<ModuleId, Error> { ) -> Result<ModuleId, Error> {
let module_map_rc = self.module_map().clone(); let module_map_rc = self.module_map.clone();
if let Some(code) = code { if let Some(code) = code {
let specifier = specifier.as_str().to_owned().into(); let specifier = specifier.as_str().to_owned().into();
let scope = &mut self.handle_scope(); let scope = &mut self.handle_scope();
@ -2429,7 +2424,7 @@ impl<const FOR_SNAPSHOT: bool> JsRuntimeImpl<FOR_SNAPSHOT> {
specifier: &ModuleSpecifier, specifier: &ModuleSpecifier,
code: Option<ModuleCode>, code: Option<ModuleCode>,
) -> Result<ModuleId, Error> { ) -> Result<ModuleId, Error> {
let module_map_rc = self.module_map().clone(); let module_map_rc = self.module_map.clone();
if let Some(code) = code { if let Some(code) = code {
let specifier = specifier.as_str().to_owned().into(); let specifier = specifier.as_str().to_owned().into();
let scope = &mut self.handle_scope(); let scope = &mut self.handle_scope();
@ -3612,8 +3607,7 @@ pub mod tests {
runtime: &mut JsRuntimeImpl<FOR_SNAPSHOT>, runtime: &mut JsRuntimeImpl<FOR_SNAPSHOT>,
modules: &Vec<ModuleInfo>, modules: &Vec<ModuleInfo>,
) { ) {
let module_map_rc = runtime.module_map(); let module_map = runtime.module_map.borrow();
let module_map = module_map_rc.borrow();
assert_eq!(module_map.handles.len(), modules.len()); assert_eq!(module_map.handles.len(), modules.len());
assert_eq!(module_map.info.len(), modules.len()); assert_eq!(module_map.info.len(), modules.len());
assert_eq!( assert_eq!(