mirror of
https://github.com/denoland/deno.git
synced 2024-12-23 15:49:44 -05:00
fix(node/fs): promises not exporting fs constants (#21997)
<!-- Before submitting a PR, please read https://deno.com/manual/contributing 1. Give the PR a descriptive title. Examples of good title: - fix(std/http): Fix race condition in server - docs(console): Update docstrings - feat(doc): Handle nested reexports Examples of bad title: - fix #7123 - update docs - fix bugs 2. Ensure there is a related issue and it is referenced in the PR text. 3. Ensure there are tests that cover the changes. 4. Ensure `cargo test` passes. 5. Ensure `./tools/format.js` passes without changing files. 6. Ensure `./tools/lint.js` passes. 7. Open as a draft PR if your work is still in progress. The CI won't run all steps, but you can add '[ci]' to a commit message to force it to. 8. If you would like to run the benchmarks on the CI, add the 'ci-bench' label. --> We were missing the `constants` export in the promise `fs` API which is available in node. ```ts import { constants, promises } from "node:fs"; import { constants as fsPromiseConstants } from "node:fs/promises"; console.log(constants === promises.constants); // logs: true console.log(constants === fsPromiseConstants); // logs: true ``` Fixes https://github.com/denoland/deno/issues/21994
This commit is contained in:
parent
28f64171cb
commit
692738232b
3 changed files with 24 additions and 2 deletions
|
@ -1,9 +1,21 @@
|
|||
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
|
||||
|
||||
import { assert, assertThrows } from "../../../test_util/std/assert/mod.ts";
|
||||
import {
|
||||
assert,
|
||||
assertEquals,
|
||||
assertThrows,
|
||||
} from "../../../test_util/std/assert/mod.ts";
|
||||
import { join } from "node:path";
|
||||
import { tmpdir } from "node:os";
|
||||
import { existsSync, mkdtempSync, readFileSync, writeFileSync } from "node:fs";
|
||||
import {
|
||||
constants,
|
||||
existsSync,
|
||||
mkdtempSync,
|
||||
promises,
|
||||
readFileSync,
|
||||
writeFileSync,
|
||||
} from "node:fs";
|
||||
import { constants as fsPromiseConstants } from "node:fs/promises";
|
||||
import { pathToAbsoluteFileUrl } from "../unit/test_util.ts";
|
||||
|
||||
Deno.test(
|
||||
|
@ -80,3 +92,11 @@ Deno.test(
|
|||
assert(!existsSync("bad_filename"));
|
||||
},
|
||||
);
|
||||
|
||||
Deno.test(
|
||||
"[node/fs/promises constants] is the same as from node:fs",
|
||||
() => {
|
||||
assertEquals(constants, fsPromiseConstants);
|
||||
assertEquals(constants, promises.constants);
|
||||
},
|
||||
);
|
||||
|
|
|
@ -137,6 +137,7 @@ const {
|
|||
|
||||
const promises = {
|
||||
access: accessPromise,
|
||||
constants,
|
||||
copyFile: copyFilePromise,
|
||||
cp: cpPromise,
|
||||
open: openPromise,
|
||||
|
|
|
@ -2,6 +2,7 @@
|
|||
import { promises as fsPromises } from "node:fs";
|
||||
|
||||
export const access = fsPromises.access;
|
||||
export const constants = fsPromises.constants;
|
||||
export const copyFile = fsPromises.copyFile;
|
||||
export const open = fsPromises.open;
|
||||
export const opendir = fsPromises.opendir;
|
||||
|
|
Loading…
Reference in a new issue