foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

chore: tweak warning message for un-run install scripts (#24508)

Browse source 
Previously when we printed out the packages that skipped install
scripts, we didn't prefix them with `npm:`. When you pass
`--allow-scripts` though, we require `npm:`, which means you can't just
copy paste the package name from the warning message.
This commit is contained in:
Nathan Whitaker 2024-07-10 11:03:41 -07:00 committed by GitHub
parent 26288cf2a9
commit 69afa8718f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cli/npm/managed/resolvers/local.rs
View file

@ -721,7 +721,7 @@ async fn sync_resolution_with_fs(
};
let packages = packages_with_scripts_not_run
.iter()
.map(|p| p.to_string())
.map(|p| format!("npm:{p}"))
.collect::<Vec<_>>()
.join(", ");
log::warn!("{}: Packages contained npm lifecycle scripts (preinstall/install/postinstall) that were not executed.

2
tests/specs/npm/lifecycle_scripts/all_lifecycles_not_run.out
View file

@ -9,4 +9,4 @@ Initialize @denotest/bin@1.0.0
warning: Packages contained npm lifecycle scripts (preinstall/install/postinstall) that were not executed.
This may cause the packages to not work correctly. To run them, use the `--allow-scripts` flag with `deno cache`
(e.g. `deno cache --allow-scripts=pkg1,pkg2 <entrypoint>`):
@denotest/node-lifecycle-scripts@1.0.0
npm:@denotest/node-lifecycle-scripts@1.0.0

2
tests/specs/npm/lifecycle_scripts/future_install_all_lifecycles_not_run.out
View file

@ -10,4 +10,4 @@ Initialize @denotest/bin@1.0.0
warning: Packages contained npm lifecycle scripts (preinstall/install/postinstall) that were not executed.
This may cause the packages to not work correctly. To run them, use the `--allow-scripts` flag with `deno cache` or `deno install`
(e.g. `deno cache --allow-scripts=pkg1,pkg2 <entrypoint>` or `deno install --allow-scripts=pkg1,pkg2`):
@denotest/node-lifecycle-scripts@1.0.0
npm:@denotest/node-lifecycle-scripts@1.0.0

2
tests/specs/npm/lifecycle_scripts/node_gyp_not_run.out
View file

@ -4,6 +4,6 @@ Download http://localhost:4260/node-gyp
warning: Packages contained npm lifecycle scripts (preinstall/install/postinstall) that were not executed.
This may cause the packages to not work correctly. To run them, use the `--allow-scripts` flag with `deno cache`
(e.g. `deno cache --allow-scripts=pkg1,pkg2 <entrypoint>`):
@denotest/node-addon@1.0.0
npm:@denotest/node-addon@1.0.0
error: Uncaught (in promise) Error: Cannot find module './build/Release/node_addon'
[WILDCARD]