From 6f9c0a9b7a4afd0d73ab312347427e445c67f6c9 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Tue, 14 Mar 2023 23:55:04 -0400 Subject: [PATCH] chore(ci): escape quotes in "Lint PR title" step (#18200) --- .github/workflows/ci.generate.ts | 6 ++++-- .github/workflows/ci.yml | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.generate.ts b/.github/workflows/ci.generate.ts index ed69395723..1d68439d69 100755 --- a/.github/workflows/ci.generate.ts +++ b/.github/workflows/ci.generate.ts @@ -481,8 +481,10 @@ const ci = { { name: "Lint PR title", if: "matrix.job == 'lint' && github.event_name == 'pull_request'", - run: - "deno run ./tools/verify_pr_title.js '${{ github.event.pull_request.title }}'", + env: { + PR_TITLE: "${{ github.event.pull_request.title }}", + }, + run: 'deno run ./tools/verify_pr_title.js "$PR_TITLE"', }, { name: "lint.js", diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 93fa95d6f2..61a2ac6b69 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -295,7 +295,9 @@ jobs: run: deno run --unstable --allow-write --allow-read --allow-run ./tools/format.js --check - name: Lint PR title if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (steps.exit_early.outputs.EXIT_EARLY != ''true'' && (matrix.job == ''lint'' && github.event_name == ''pull_request''))' - run: 'deno run ./tools/verify_pr_title.js ''${{ github.event.pull_request.title }}''' + env: + PR_TITLE: '${{ github.event.pull_request.title }}' + run: deno run ./tools/verify_pr_title.js "$PR_TITLE" - name: lint.js if: '!(github.event_name == ''pull_request'' && matrix.skip_pr) && (steps.exit_early.outputs.EXIT_EARLY != ''true'' && (matrix.job == ''lint''))' run: deno run --unstable --allow-write --allow-read --allow-run ./tools/lint.js