foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-10-29 08:58:01 -04:00
Code Issues Wiki Activity

fix sparse array inspection (#16204)

Browse source 
fix https://github.com/denoland/deno/issues/16202
This commit is contained in:
sigmaSd 2022-10-10 15:22:21 +01:00 committed by GitHub
parent 1ab3691b09
commit 70ad6717df
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
cli/tests/unit/console_test.ts
View file

@ -770,6 +770,16 @@ Deno.test(function consoleTestStringifyIterable() {
`[ <1 empty item> ]`, `[ <1 empty item> ]`,
); );
assertEquals(
stringify([, , 1]),
`[ <2 empty items>, 1 ]`,
);
assertEquals(
stringify([1, , , 1]),
`[ 1, <2 empty items>, 1 ]`,
);
const withEmptyElAndMoreItems = Array(500); const withEmptyElAndMoreItems = Array(500);
withEmptyElAndMoreItems.fill(0, 50, 80); withEmptyElAndMoreItems.fill(0, 50, 80);
withEmptyElAndMoreItems.fill(2, 100, 120); withEmptyElAndMoreItems.fill(2, 100, 120);

8
ext/console/02_console.js
View file

@ -417,6 +417,7 @@
} }
} }
let entriesLengthWithoutEmptyItems = entriesLength;
if (options.typeName === "Array") { if (options.typeName === "Array") {
for ( for (
let i = 0, j = 0; let i = 0, j = 0;
@ -433,7 +434,7 @@
if (skipTo) { if (skipTo) {
// subtract skipped (empty) items // subtract skipped (empty) items
entriesLength -= skipTo - i; entriesLengthWithoutEmptyItems -= skipTo - i;
i = skipTo; i = skipTo;
} }
} }
@ -478,8 +479,9 @@
ArrayPrototypeSort(entries); ArrayPrototypeSort(entries);
} }
if (entriesLength > inspectOptions.iterableLimit) { if (entriesLengthWithoutEmptyItems > inspectOptions.iterableLimit) {
const nmore = entriesLength - inspectOptions.iterableLimit; const nmore = entriesLengthWithoutEmptyItems -
inspectOptions.iterableLimit;
ArrayPrototypePush(entries, `... ${nmore} more items`); ArrayPrototypePush(entries, `... ${nmore} more items`);
} }