foster/denoland-deno
0
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-10-29 08:58:01 -04:00
Code Issues Wiki Activity

fix: plugin ops should change op count metrics (#3455)

Browse source
This commit is contained in:
Luca Casonato 2019-12-07 21:09:09 +01:00 committed by Ry Dahl
parent e02029c602
commit 7144bbed34
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
cli/ops/plugins.rs
View file

@ -86,7 +86,8 @@ pub fn op_open_plugin(
// The inclusion of prefix and rid is designed to avoid any
// op name collision beyond the bound of a single loaded
// plugin instance.
let op_id = registry.register(&format!("plugin_{}_{}", rid, op.0), op.1);
let op_id = registry
.register(&format!("plugin_{}_{}", rid, op.0), state.core_op(op.1));
plugin_resource.ops.insert(op.0, op_id);
}

19
test_plugin/tests/test.js
View file

@ -43,5 +43,24 @@ function runTestAsync() {
}
}
function runTestOpCount() {
const start = Deno.metrics();
testSync.dispatch(new Uint8Array([116, 101, 115, 116]));
const end = Deno.metrics();
if (end.opsCompleted - start.opsCompleted !== 2) {
// one op for the plugin and one for Deno.metrics
throw new Error("The opsCompleted metric is not correct!");
}
if (end.opsDispatched - start.opsDispatched !== 2) {
// one op for the plugin and one for Deno.metrics
throw new Error("The opsDispatched metric is not correct!");
}
}
runTestSync();
runTestAsync();
runTestOpCount();