foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-08 07:08:27 -05:00
Code Issues Packages 1 Wiki Activity

chore(core): Remove a note that is no longer relevant. (#14069)

Browse source 
This note about how `v8::SnapshotCreator::create_blob` must not be
called from a `HandleScope` stopped being relevant in #6801, and was
now attached to code that had nothing to do with `HandleScope`s.
This commit is contained in:
Andreu Botella 2022-03-22 22:57:15 +01:00 committed by Kitson Kelly
parent fb6e135b3e
commit 71de0c92b8
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
core/runtime.rs
View file

@ -650,8 +650,6 @@ impl JsRuntime {
let state = Self::state(self.v8_isolate()); let state = Self::state(self.v8_isolate());
// Note: create_blob() method must not be called from within a HandleScope.
// TODO(piscisaureus): The rusty_v8 type system should enforce this.
state.borrow_mut().global_context.take(); state.borrow_mut().global_context.take();
self.inspector.take(); self.inspector.take();