foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-26 16:09:27 -05:00
Code Issues Packages 1 Wiki Activity

chore(cli/flags): Rename --failfast to --fail-fast (#8456)

Browse source
This commit is contained in:
Nayeem Rahman 2020-11-22 14:40:33 +00:00 committed by GitHub
parent 2c00f6c548
commit 7405356e23
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
cli/flags.rs
View file

@ -574,7 +574,7 @@ fn test_parse(flags: &mut Flags, matches: &clap::ArgMatches) {
runtime_args_parse(flags, matches, true); runtime_args_parse(flags, matches, true);
let no_run = matches.is_present("no-run"); let no_run = matches.is_present("no-run");
let failfast = matches.is_present("failfast"); let fail_fast = matches.is_present("fail-fast");
let allow_none = matches.is_present("allow-none"); let allow_none = matches.is_present("allow-none");
let quiet = matches.is_present("quiet"); let quiet = matches.is_present("quiet");
let filter = matches.value_of("filter").map(String::from); let filter = matches.value_of("filter").map(String::from);
@ -609,7 +609,7 @@ fn test_parse(flags: &mut Flags, matches: &clap::ArgMatches) {
flags.subcommand = DenoSubcommand::Test { flags.subcommand = DenoSubcommand::Test {
no_run, no_run,
fail_fast: failfast, fail_fast,
quiet, quiet,
include, include,
filter, filter,
@ -1158,8 +1158,9 @@ fn test_subcommand<'a, 'b>() -> App<'a, 'b> {
.requires("unstable"), .requires("unstable"),
) )
.arg( .arg(
Arg::with_name("failfast") Arg::with_name("fail-fast")
.long("failfast") .long("fail-fast")
.alias("failfast")
.help("Stop on first error") .help("Stop on first error")
.takes_value(false), .takes_value(false),
) )

2
cli/tests/integration_tests.rs
View file

@ -1887,7 +1887,7 @@ itest!(deno_test {
}); });
itest!(deno_test_fail_fast { itest!(deno_test_fail_fast {
args: "test --failfast test_runner_test.ts", args: "test --fail-fast test_runner_test.ts",
exit_code: 1, exit_code: 1,
output: "deno_test_fail_fast.out", output: "deno_test_fail_fast.out",
}); });

4
docs/testing.md
View file

@ -199,10 +199,10 @@ Deno.test({
## Failing fast ## Failing fast
If you have a long running test suite and wish for it to stop on the first If you have a long running test suite and wish for it to stop on the first
failure, you can specify the `--failfast` flag when running the suite. failure, you can specify the `--fail-fast` flag when running the suite.
```shell ```shell
deno test --failfast deno test --fail-fast
``` ```
## Test coverage ## Test coverage