From 74e59abc5b3d78254cabcbd85d485081018fbef5 Mon Sep 17 00:00:00 2001 From: Maxime Guerreiro Date: Tue, 22 Jun 2021 17:47:09 +0200 Subject: [PATCH] cleanup(core): top-level-await is now always enabled (#11082) Starting with V8 9.1, top-level-await is always enabled by default. See https://v8.dev/blog/v8-release-91 for the release notes. - Remove the now redundant v8 flag. - Clarify doc comment and add link to the feature explainer. --- core/runtime.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/core/runtime.rs b/core/runtime.rs index 0dad941289..e9f6601b08 100644 --- a/core/runtime.rs +++ b/core/runtime.rs @@ -160,7 +160,6 @@ fn v8_init(v8_platform: Option>) { // See https://github.com/denoland/deno/issues/2544 " --experimental-wasm-threads", " --no-wasm-async-compilation", - " --harmony-top-level-await", " --harmony-import-assertions", " --no-validate-asm", ); @@ -1133,9 +1132,9 @@ impl JsRuntime { } } - /// "deno_core" runs V8 with "--harmony-top-level-await" - /// flag on - it means that each module evaluation returns a promise - /// from V8. + /// "deno_core" runs V8 with Top Level Await enabled. It means that each + /// module evaluation returns a promise from V8. + /// Feature docs: https://v8.dev/features/top-level-await /// /// This promise resolves after all dependent modules have also /// resolved. Each dependent module may perform calls to "import()" and APIs