foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-23 07:44:48 -05:00
Code Issues Packages 1 Wiki Activity

fix: invalid blob type (#4536)

Browse source
This commit is contained in:
crowlKats 2020-03-31 20:42:18 +02:00 committed by GitHub
parent d4d0b5d90c
commit 7b675a332c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cli/js/tests/blob_test.ts
View file

@ -32,6 +32,14 @@ unitTest(function blobSlice(): void {
assertEquals(b4.size, blob.size); assertEquals(b4.size, blob.size);
}); });
unitTest(function blobInvalidType(): void {
const blob = new Blob(["foo"], {
type: "\u0521",
});
assertEquals(blob.type, "");
});
unitTest(function blobShouldNotThrowError(): void { unitTest(function blobShouldNotThrowError(): void {
let hasThrown = false; let hasThrown = false;

11
cli/js/web/blob.ts
View file

@ -139,14 +139,11 @@ export class DenoBlob implements domTypes.Blob {
} }
const { ending = "transparent", type = "" } = options ?? {}; const { ending = "transparent", type = "" } = options ?? {};
if (!containsOnlyASCII(type)) {
const errMsg = "The 'type' property must consist of ASCII characters.";
throw new SyntaxError(errMsg);
}
const bytes = processBlobParts(blobParts!, { ending, type });
// Normalize options.type. // Normalize options.type.
let normalizedType = type; let normalizedType = type;
if (!containsOnlyASCII(type)) {
normalizedType = "";
} else {
if (type.length) { if (type.length) {
for (let i = 0; i < type.length; ++i) { for (let i = 0; i < type.length; ++i) {
const char = type[i]; const char = type[i];
@ -157,6 +154,8 @@ export class DenoBlob implements domTypes.Blob {
} }
normalizedType = type.toLowerCase(); normalizedType = type.toLowerCase();
} }
}
const bytes = processBlobParts(blobParts!, { ending, type });
// Set Blob object's properties. // Set Blob object's properties.
this[bytesSymbol] = bytes; this[bytesSymbol] = bytes;
this.size = bytes.byteLength; this.size = bytes.byteLength;