foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-25 16:49:18 -05:00
Code Issues Packages 1 Wiki Activity

chore: disable another flaky Node compat test (#20872)

Browse source
This commit is contained in:
Bartek Iwańczuk 2023-10-10 20:17:11 +02:00 committed by GitHub
parent 0606c11403
commit 7b80b27a96
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 135 additions and 119 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

254
cli/tests/node_compat/test/internet/test-dns.js
View file

@ -260,24 +260,26 @@ TEST(async function test_resolveSrv(done) {
checkWrap(req);
});
TEST(function test_resolveSrv_failure(done) {
dnsPromises.resolveSrv(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveSrv_failure(done) {
// dnsPromises.resolveSrv(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));
const req = dns.resolveSrv(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveSrv(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');
// assert.strictEqual(result, undefined);
// done();
// });
assert.strictEqual(result, undefined);
done();
});
checkWrap(req);
});
// checkWrap(req);
// });
TEST(async function test_resolvePtr(done) {
function validateResult(result) {
@ -300,24 +302,26 @@ TEST(async function test_resolvePtr(done) {
checkWrap(req);
});
TEST(function test_resolvePtr_failure(done) {
dnsPromises.resolvePtr(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolvePtr_failure(done) {
// dnsPromises.resolvePtr(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));
const req = dns.resolvePtr(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolvePtr(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);
done();
});
// done();
// });
checkWrap(req);
});
// checkWrap(req);
// });
TEST(async function test_resolveNaptr(done) {
function validateResult(result) {
@ -345,24 +349,26 @@ TEST(async function test_resolveNaptr(done) {
checkWrap(req);
});
TEST(function test_resolveNaptr_failure(done) {
dnsPromises.resolveNaptr(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveNaptr_failure(done) {
// dnsPromises.resolveNaptr(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));
const req = dns.resolveNaptr(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveNaptr(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);
done();
});
// done();
// });
checkWrap(req);
});
// checkWrap(req);
// });
TEST(async function test_resolveSoa(done) {
function validateResult(result) {
@ -394,24 +400,26 @@ TEST(async function test_resolveSoa(done) {
checkWrap(req);
});
TEST(function test_resolveSoa_failure(done) {
dnsPromises.resolveSoa(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveSoa_failure(done) {
// dnsPromises.resolveSoa(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));
const req = dns.resolveSoa(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveSoa(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);
done();
});
// done();
// });
checkWrap(req);
});
// checkWrap(req);
// });
TEST(async function test_resolveCaa(done) {
function validateResult(result) {
@ -456,24 +464,26 @@ TEST(async function test_resolveCaa(done) {
// checkWrap(req);
// });
TEST(function test_resolveCname_failure(done) {
dnsPromises.resolveCname(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveCname_failure(done) {
// dnsPromises.resolveCname(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));
const req = dns.resolveCname(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveCname(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);
done();
});
// done();
// });
checkWrap(req);
});
// checkWrap(req);
// });
TEST(async function test_resolveTxt(done) {
@ -494,24 +504,26 @@ TEST(async function test_resolveTxt(done) {
checkWrap(req);
});
TEST(function test_resolveTxt_failure(done) {
dnsPromises.resolveTxt(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.mustCall((err) => {
assert.strictEqual(err.code, 'ENOTFOUND');
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolveTxt_failure(done) {
// dnsPromises.resolveTxt(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.mustCall((err) => {
// assert.strictEqual(err.code, 'ENOTFOUND');
// }));
const req = dns.resolveTxt(addresses.NOT_FOUND, function(err, result) {
assert.ok(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND');
// const req = dns.resolveTxt(addresses.NOT_FOUND, function(err, result) {
// assert.ok(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND');
assert.strictEqual(result, undefined);
// assert.strictEqual(result, undefined);
done();
});
// done();
// });
checkWrap(req);
});
// checkWrap(req);
// });
TEST(function test_lookup_failure(done) {
@ -667,48 +679,52 @@ TEST(async function test_lookup_all_mixed(done) {
// });
TEST(function test_lookup_failure(done) {
dnsPromises.lookup(addresses.NOT_FOUND)
.then(common.mustNotCall())
.catch(common.expectsError({
code: 'ENOTFOUND',
hostname: addresses.NOT_FOUND
}));
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_lookup_failure(done) {
// dnsPromises.lookup(addresses.NOT_FOUND)
// .then(common.mustNotCall())
// .catch(common.expectsError({
// code: 'ENOTFOUND',
// hostname: addresses.NOT_FOUND
// }));
const req = dns.lookup(addresses.NOT_FOUND, (err) => {
assert(err instanceof Error);
assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
assert.strictEqual(err.hostname, addresses.NOT_FOUND);
assert.ok(err.message.includes(addresses.NOT_FOUND));
// const req = dns.lookup(addresses.NOT_FOUND, (err) => {
// assert(err instanceof Error);
// assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
// assert.strictEqual(err.hostname, addresses.NOT_FOUND);
// assert.ok(err.message.includes(addresses.NOT_FOUND));
done();
});
// done();
// });
checkWrap(req);
});
// checkWrap(req);
// });
TEST(function test_resolve_failure(done) {
const req = dns.resolve4(addresses.NOT_FOUND, (err) => {
assert(err instanceof Error);
// TODO(bartlomieju): this test became very flaky on CI, returning `UNKNOWN`
// instead of `ENOTFOUND`.
// TEST(function test_resolve_failure(done) {
// const req = dns.resolve4(addresses.NOT_FOUND, (err) => {
// assert(err instanceof Error);
switch (err.code) {
case 'ENOTFOUND':
case 'ESERVFAIL':
break;
default:
assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
break;
}
// switch (err.code) {
// case 'ENOTFOUND':
// case 'ESERVFAIL':
// break;
// default:
// assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
// break;
// }
assert.strictEqual(err.hostname, addresses.NOT_FOUND);
assert.ok(err.message.includes(addresses.NOT_FOUND));
// assert.strictEqual(err.hostname, addresses.NOT_FOUND);
// assert.ok(err.message.includes(addresses.NOT_FOUND));
done();
});
// done();
// });
checkWrap(req);
});
// checkWrap(req);
// });
let getaddrinfoCallbackCalled = false;