mirror of
https://github.com/denoland/deno.git
synced 2024-11-21 15:04:11 -05:00
fix(repl): remove check flags (#26140)
This change removes the handling of `--check` and `--no-check` flags from `deno repl` subcommand. Currently these flags don't have effects, and the help output for these options are incorrect and confusing. closes #26042
This commit is contained in:
parent
ae6a2b23ba
commit
7bfec38173
1 changed files with 25 additions and 8 deletions
|
@ -2769,8 +2769,13 @@ It is especially useful for quick prototyping and checking snippets of code.
|
||||||
|
|
||||||
TypeScript is supported, however it is not type-checked, only transpiled."
|
TypeScript is supported, however it is not type-checked, only transpiled."
|
||||||
), UnstableArgsConfig::ResolutionAndRuntime)
|
), UnstableArgsConfig::ResolutionAndRuntime)
|
||||||
.defer(|cmd| runtime_args(cmd, true, true, true)
|
.defer(|cmd| {
|
||||||
.arg(check_arg(false))
|
let cmd = compile_args_without_check_args(cmd);
|
||||||
|
let cmd = inspect_args(cmd);
|
||||||
|
let cmd = permission_args(cmd, None);
|
||||||
|
let cmd = runtime_misc_args(cmd);
|
||||||
|
|
||||||
|
cmd
|
||||||
.arg(
|
.arg(
|
||||||
Arg::new("eval-file")
|
Arg::new("eval-file")
|
||||||
.long("eval-file")
|
.long("eval-file")
|
||||||
|
@ -2789,7 +2794,7 @@ TypeScript is supported, however it is not type-checked, only transpiled."
|
||||||
.after_help(cstr!("<y>Environment variables:</>
|
.after_help(cstr!("<y>Environment variables:</>
|
||||||
<g>DENO_REPL_HISTORY</> Set REPL history file path. History file is disabled when the value is empty.
|
<g>DENO_REPL_HISTORY</> Set REPL history file path. History file is disabled when the value is empty.
|
||||||
<p(245)>[default: $DENO_DIR/deno_history.txt]</>"))
|
<p(245)>[default: $DENO_DIR/deno_history.txt]</>"))
|
||||||
)
|
})
|
||||||
.arg(env_file_arg())
|
.arg(env_file_arg())
|
||||||
.arg(
|
.arg(
|
||||||
Arg::new("args")
|
Arg::new("args")
|
||||||
|
@ -3662,6 +3667,10 @@ fn runtime_args(
|
||||||
} else {
|
} else {
|
||||||
app
|
app
|
||||||
};
|
};
|
||||||
|
runtime_misc_args(app)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn runtime_misc_args(app: Command) -> Command {
|
||||||
app
|
app
|
||||||
.arg(frozen_lockfile_arg())
|
.arg(frozen_lockfile_arg())
|
||||||
.arg(cached_only_arg())
|
.arg(cached_only_arg())
|
||||||
|
@ -4880,8 +4889,18 @@ fn repl_parse(
|
||||||
flags: &mut Flags,
|
flags: &mut Flags,
|
||||||
matches: &mut ArgMatches,
|
matches: &mut ArgMatches,
|
||||||
) -> clap::error::Result<()> {
|
) -> clap::error::Result<()> {
|
||||||
runtime_args_parse(flags, matches, true, true, true)?;
|
unstable_args_parse(flags, matches, UnstableArgsConfig::ResolutionAndRuntime);
|
||||||
unsafely_ignore_certificate_errors_parse(flags, matches);
|
compile_args_without_check_parse(flags, matches)?;
|
||||||
|
cached_only_arg_parse(flags, matches);
|
||||||
|
frozen_lockfile_arg_parse(flags, matches);
|
||||||
|
permission_args_parse(flags, matches)?;
|
||||||
|
inspect_arg_parse(flags, matches);
|
||||||
|
location_arg_parse(flags, matches);
|
||||||
|
v8_flags_arg_parse(flags, matches);
|
||||||
|
seed_arg_parse(flags, matches);
|
||||||
|
enable_testing_features_arg_parse(flags, matches);
|
||||||
|
env_file_arg_parse(flags, matches);
|
||||||
|
strace_ops_parse(flags, matches);
|
||||||
|
|
||||||
let eval_files = matches
|
let eval_files = matches
|
||||||
.remove_many::<String>("eval-file")
|
.remove_many::<String>("eval-file")
|
||||||
|
@ -7429,7 +7448,7 @@ mod tests {
|
||||||
#[test]
|
#[test]
|
||||||
fn repl_with_flags() {
|
fn repl_with_flags() {
|
||||||
#[rustfmt::skip]
|
#[rustfmt::skip]
|
||||||
let r = flags_from_vec(svec!["deno", "repl", "-A", "--import-map", "import_map.json", "--no-remote", "--config", "tsconfig.json", "--no-check", "--reload", "--lock", "lock.json", "--cert", "example.crt", "--cached-only", "--location", "https:foo", "--v8-flags=--help", "--seed", "1", "--inspect=127.0.0.1:9229", "--unsafely-ignore-certificate-errors", "--env=.example.env"]);
|
let r = flags_from_vec(svec!["deno", "repl", "-A", "--import-map", "import_map.json", "--no-remote", "--config", "tsconfig.json", "--reload", "--lock", "lock.json", "--cert", "example.crt", "--cached-only", "--location", "https:foo", "--v8-flags=--help", "--seed", "1", "--inspect=127.0.0.1:9229", "--unsafely-ignore-certificate-errors", "--env=.example.env"]);
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
r.unwrap(),
|
r.unwrap(),
|
||||||
Flags {
|
Flags {
|
||||||
|
@ -7477,7 +7496,6 @@ mod tests {
|
||||||
allow_write: Some(vec![]),
|
allow_write: Some(vec![]),
|
||||||
..Default::default()
|
..Default::default()
|
||||||
},
|
},
|
||||||
type_check_mode: TypeCheckMode::None,
|
|
||||||
..Flags::default()
|
..Flags::default()
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
@ -7499,7 +7517,6 @@ mod tests {
|
||||||
eval: None,
|
eval: None,
|
||||||
is_default_command: false,
|
is_default_command: false,
|
||||||
}),
|
}),
|
||||||
type_check_mode: TypeCheckMode::None,
|
|
||||||
..Flags::default()
|
..Flags::default()
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
|
|
Loading…
Reference in a new issue