From 81372e82671cace7774daa5c42413b682acb89c4 Mon Sep 17 00:00:00 2001 From: Kitson Kelly Date: Fri, 1 Feb 2019 13:31:26 +1000 Subject: [PATCH] Add item to CONTRIBUTING.md about needing tests This adds requiring tests covering the change as a pre-req before raising a PR. --- .github/CONTRIBUTING.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index e2965ac95e..cf6a2968b9 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -17,9 +17,10 @@ Docs are [here](https://github.com/denoland/deno/blob/master/Docs.md). Before submitting, please make sure the following is done: -1. Ensure `./tools/test.py` passes. -2. Format your code with `./tools/format.ts`. -3. Make sure `./tools/lint.py` passes. +1. There are tests that cover the changes. +2. Ensure `./tools/test.py` passes. +3. Format your code with `./tools/format.ts`. +4. Make sure `./tools/lint.py` passes. ## Changes to `third_party`