foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity

Update contribution guidelines (#1771)

Browse source 
To make it clearer how people should indicate that are contributing to Deno.
This commit is contained in:
Kitson Kelly 2019-02-14 12:12:11 +11:00 committed by Ryan Dahl
parent 8d1567fafb
commit 8686f49ee4
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
website/manual.md
View file

@ -609,14 +609,18 @@ Please don't make [the benchmarks](https://deno.land/benchmarks.html) worse.
Ask for help in the [community chat room](https://gitter.im/denolife/Lobby).
If you are going to work on an issue, mention so in the issue comments _before_
you start working on the issue.
### Submitting a pull request
Before submitting, please make sure the following is done:
1. There are tests that cover the changes.
2. Ensure `./tools/test.py` passes.
3. Format your code with `tools/format.py`
4. Make sure `./tools/lint.py` passes.
1. That there is a related issue and it is referenced in the PR text.
2. There are tests that cover the changes.
3. Ensure `./tools/test.py` passes.
4. Format your code with `tools/format.py`
5. Make sure `./tools/lint.py` passes.
### Changes to `third_party`