diff --git a/ext/node/polyfills/net.ts b/ext/node/polyfills/net.ts index ecb4132aaf..b3dfe0ec8f 100644 --- a/ext/node/polyfills/net.ts +++ b/ext/node/polyfills/net.ts @@ -703,16 +703,20 @@ function _lookupAndConnect( } else { self._unrefTimer(); - defaultTriggerAsyncIdScope( - self[asyncIdSymbol], - _internalConnect, - self, - ip, - port, - addressType, - localAddress, - localPort, - ); + defaultTriggerAsyncIdScope(self[asyncIdSymbol], nextTick, () => { + if (self.connecting) { + defaultTriggerAsyncIdScope( + self[asyncIdSymbol], + _internalConnect, + self, + ip, + port, + addressType, + localAddress, + localPort, + ); + } + }); } }, ); diff --git a/tests/unit_node/http_test.ts b/tests/unit_node/http_test.ts index 9da33b532d..fabd53748d 100644 --- a/tests/unit_node/http_test.ts +++ b/tests/unit_node/http_test.ts @@ -1074,30 +1074,24 @@ Deno.test("[node/https] node:https exports globalAgent", async () => { ); }); -Deno.test( - "[node/http] node:http request.setHeader(header, null) doesn't throw", +Deno.test("[node/http] node:http request.setHeader(header, null) doesn't throw", () => { { - ignore: true, - }, - () => { - { - const req = http.request("http://localhost:4545/"); - req.on("error", () => {}); - // @ts-expect-error - null is not a valid header value - req.setHeader("foo", null); - req.end(); - req.destroy(); - } - { - const req = https.request("https://localhost:4545/"); - req.on("error", () => {}); - // @ts-expect-error - null is not a valid header value - req.setHeader("foo", null); - req.end(); - req.destroy(); - } - }, -); + const req = http.request("http://localhost:4545/"); + req.on("error", () => {}); + // @ts-expect-error - null is not a valid header value + req.setHeader("foo", null); + req.end(); + req.destroy(); + } + { + const req = https.request("https://localhost:4545/"); + req.on("error", () => {}); + // @ts-expect-error - null is not a valid header value + req.setHeader("foo", null); + req.end(); + req.destroy(); + } +}); Deno.test("[node/http] ServerResponse getHeader", async () => { const { promise, resolve } = Promise.withResolvers();