foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-23 15:49:44 -05:00
Code Issues Packages 1 Wiki Activity

chore(cli): fix part of flaky test (#22515)

Browse source
This commit is contained in:
Matt Mastracci 2024-02-21 12:10:51 -07:00 committed by GitHub
parent bd66080217
commit 8aa529f1b8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
tests/integration/node_compat_tests.rs
View file

@ -16,6 +16,8 @@ itest!(node_test_module_no_sanitizers {
args: "test -A --no-check node/test_no_sanitizers/test.js",
output: "node/test_no_sanitizers/test.out",
envs: env_vars_for_npm_tests(),
exit_code: 123,
exit_code: 0,
// TODO(mmastrac): fix exit sanitizer part of test
// exit_code: 123,
http_server: true,
});

9
tests/testdata/node/test_no_sanitizers/test.js vendored
View file

@ -22,7 +22,8 @@ test("should not complain about resource and op sanitizers", async (t) => {
);
});
test("should allow exit", () => {
// no exit sanitizers
Deno.exit(123);
});
// TODO(mmastrac): This works, but we don't reliably flush stdout/stderr here, making this test flake
// test("should allow exit", () => {
// // no exit sanitizers
// Deno.exit(123);
// });

6
tests/testdata/node/test_no_sanitizers/test.out vendored
View file

@ -1,5 +1,7 @@
running 2 tests from ./node/test_no_sanitizers/test.js
running 1 test from ./node/test_no_sanitizers/test.js
should not complain about resource and op sanitizers ...
nested test ... ok ([WILDCARD])
should not complain about resource and op sanitizers ... ok ([WILDCARD])
should allow exit ...
ok | 1 passed (1 step) | 0 failed ([WILDCARD])