foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-09 15:48:16 -05:00
Code Issues Packages 1 Wiki Activity

feat(node/fs): Add a chmod method to the FileHandle class (#27522)

Browse source 
Add the chmod method to the FileHandle class in node compat as part of
#25554
This commit is contained in:
Nikolay Karadzhov 2025-01-07 15:58:14 +02:00 committed by GitHub
parent b7fb5a5547
commit 8cda4cf53d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 34 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/node/polyfills/_fs/_fs_open.ts
View file

@ -153,7 +153,7 @@ export function openPromise(
return new Promise((resolve, reject) => {
open(path, flags, mode, (err, fd) => {
if (err) reject(err);
else resolve(new FileHandle(fd));
else resolve(new FileHandle(fd, path));
});
});
}

19
ext/node/polyfills/internal/fs/handle.ts
View file

@ -5,7 +5,7 @@
import { EventEmitter } from "node:events";
import { Buffer } from "node:buffer";
import { promises, read, write } from "node:fs";
import { Mode, promises, read, write } from "node:fs";
export type { BigIntStats, Stats } from "ext:deno_node/_fs/_fs_stat.ts";
import {
BinaryOptionsArgument,
@ -26,11 +26,15 @@ interface ReadResult {
buffer: Buffer;
}
type Path = string | Buffer | URL;
export class FileHandle extends EventEmitter {
#rid: number;
constructor(rid: number) {
#path: Path;
constructor(rid: number, path: Path) {
super();
this.#rid = rid;
this.#path = path;
}
get fd() {
@ -144,17 +148,24 @@ export class FileHandle extends EventEmitter {
stat(options?: { bigint: boolean }): Promise<Stats | BigIntStats> {
return fsCall(promises.fstat, this, options);
}
chmod(mode: Mode): Promise<void> {
assertNotClosed(this, promises.chmod.name);
return promises.chmod(this.#path, mode);
}
}
function fsCall(fn, handle, ...args) {
function assertNotClosed(handle: FileHandle, syscall: string) {
if (handle.fd === -1) {
const err = new Error("file closed");
throw Object.assign(err, {
code: "EBADF",
syscall: fn.name,
syscall,
});
}
}
function fsCall(fn, handle, ...args) {
assertNotClosed(handle, fn.name);
return fn(handle.fd, ...args);
}

18
tests/unit_node/_fs/_fs_handle_test.ts
View file

@ -199,3 +199,21 @@ Deno.test(
assertEquals(data.length, 0);
},
);
Deno.test({
name: "[node/fs filehandle.chmod] Change the permissions of the file",
ignore: Deno.build.os === "windows",
async fn() {
const fileHandle = await fs.open(testData);
const readOnly = 0o444;
await fileHandle.chmod(readOnly.toString(8));
assertEquals(Deno.statSync(testData).mode! & 0o777, readOnly);
const readWrite = 0o666;
await fileHandle.chmod(readWrite.toString(8));
assertEquals(Deno.statSync(testData).mode! & 0o777, readWrite);
await fileHandle.close();
},
});