foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-06 22:35:51 -05:00
Code Issues Packages 1 Wiki Activity

enable a test case 'ClientRequest search params'

Browse source
This commit is contained in:
Yoshiya Hinosawa 2024-10-03 17:58:25 +09:00
parent 007b5265b8
commit 8d41fbc2da
No known key found for this signature in database
GPG key ID: 9017DB4559488785
2 changed files with 9 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
ext/node/ops/http.rs
View file

@ -167,9 +167,11 @@ where
let mut request = http::Request::new(body); let mut request = http::Request::new(body);
*request.method_mut() = method.clone(); *request.method_mut() = method.clone();
*request.uri_mut() = url_parsed let path = url_parsed.path();
.path() let query = url_parsed.query();
.to_string() *request.uri_mut() = query
.map(|q| format!("{}?{}", path, q))
.unwrap_or_else(|| path.to_string())
.parse() .parse()
.map_err(|_| type_error("Invalid URL"))?; .map_err(|_| type_error("Invalid URL"))?;
*request.headers_mut() = header_map; *request.headers_mut() = header_map;

9
tests/unit_node/http_test.ts
View file

@ -794,14 +794,13 @@ Deno.test("[node/http] ClientRequest PUT", async () => {
assertEquals(body, "hello world"); assertEquals(body, "hello world");
}); });
Deno.test("[node/http] ClientRequest search params", { Deno.test("[node/http] ClientRequest search params", async () => {
ignore: true,
}, async () => {
let body = ""; let body = "";
const { promise, resolve, reject } = Promise.withResolvers<void>(); const { promise, resolve, reject } = Promise.withResolvers<void>();
const req = http.request({ const req = http.request({
host: "localhost:4545", host: "localhost",
path: "search_params?foo=bar", port: 4545,
path: "/search_params?foo=bar",
}, (resp) => { }, (resp) => {
resp.on("data", (chunk) => { resp.on("data", (chunk) => {
body += chunk; body += chunk;