foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

fix(console/ext/repl): support using parseFloat() (#25900)

Browse source 
Fixes #21428

Co-authored-by: tannal <tannal2409@gmail.com>
This commit is contained in:
Mohammad Sulaiman 2024-10-15 01:04:18 +03:00 committed by GitHub
parent 48cbf85add
commit 8dbe77dd29
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 46 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ext/console/01_console.js
View file

@ -84,6 +84,7 @@ const {
NumberIsInteger,
NumberIsNaN,
NumberParseInt,
NumberParseFloat,
NumberPrototypeToFixed,
NumberPrototypeToString,
NumberPrototypeValueOf,
@ -3010,20 +3011,18 @@ function inspectArgs(args, inspectOptions = { __proto__: null }) {
} else if (ArrayPrototypeIncludes(["d", "i"], char)) {
// Format as an integer.
const value = args[a++];
if (typeof value == "bigint") {
formattedArg = `${value}n`;
} else if (typeof value == "number") {
formattedArg = `${NumberParseInt(String(value))}`;
} else {
if (typeof value === "symbol") {
formattedArg = "NaN";
} else {
formattedArg = `${NumberParseInt(value)}`;
}
} else if (char == "f") {
// Format as a floating point value.
const value = args[a++];
if (typeof value == "number") {
formattedArg = `${value}`;
} else {
if (typeof value === "symbol") {
formattedArg = "NaN";
} else {
formattedArg = `${NumberParseFloat(value)}`;
}
} else if (ArrayPrototypeIncludes(["O", "o"], char)) {
// Format as an object.

14
tests/integration/repl_tests.rs
View file

@ -255,6 +255,20 @@ fn console_log() {
console.write_line("'world'");
console.expect("\"world\"");
});
// https://github.com/denoland/deno/issues/21428
let (out, err) = util::run_and_collect_output_with_args(
true,
vec![
"repl",
"--eval-file=./../specs/repl/console_log/093_console_log_format.js",
],
None,
None,
false,
);
assert_contains!(out, "0.5");
assert!(err.is_empty());
}
#[test]

16
tests/specs/repl/console_log/093_console_log_format.js Normal file
View file

@ -0,0 +1,16 @@
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
class Frac {
constructor(num, den) {
this.num = num;
this.den = den;
}
[Symbol.toPrimitive]() {
return this.num / this.den;
}
display() {
const result = this.num / this.den;
process.stdout.write(`${result}`);
}
}
const f = new Frac(1, 2);
f.display();

1
tests/specs/repl/console_log/093_console_log_format.out Normal file
View file

@ -0,0 +1 @@
0.5

4
tests/specs/repl/console_log/__test__.jsonc Normal file
View file

@ -0,0 +1,4 @@
{
"args": "run -A --quiet 093_console_log_format.js",
"output": "093_console_log_format.out"
}

8
tests/unit/console_test.ts
View file

@ -1162,7 +1162,7 @@ Deno.test(function consoleTestWithIntegerFormatSpecifier() {
assertEquals(stringify("%i"), "%i");
assertEquals(stringify("%i", 42.0), "42");
assertEquals(stringify("%i", 42), "42");
assertEquals(stringify("%i", "42"), "NaN");
assertEquals(stringify("%i", "42"), "42");
assertEquals(stringify("%i", 1.5), "1");
assertEquals(stringify("%i", -0.5), "0");
assertEquals(stringify("%i", ""), "NaN");
@ -1172,7 +1172,7 @@ Deno.test(function consoleTestWithIntegerFormatSpecifier() {
assertEquals(stringify("%d", 12345678901234567890123), "1");
assertEquals(
stringify("%i", 12345678901234567890123n),
"12345678901234567890123n",
"1.2345678901234568e+22",
);
});
@ -1180,13 +1180,13 @@ Deno.test(function consoleTestWithFloatFormatSpecifier() {
assertEquals(stringify("%f"), "%f");
assertEquals(stringify("%f", 42.0), "42");
assertEquals(stringify("%f", 42), "42");
assertEquals(stringify("%f", "42"), "NaN");
assertEquals(stringify("%f", "42"), "42");
assertEquals(stringify("%f", 1.5), "1.5");
assertEquals(stringify("%f", -0.5), "-0.5");
assertEquals(stringify("%f", Math.PI), "3.141592653589793");
assertEquals(stringify("%f", ""), "NaN");
assertEquals(stringify("%f", Symbol("foo")), "NaN");
assertEquals(stringify("%f", 5n), "NaN");
assertEquals(stringify("%f", 5n), "5");
assertEquals(stringify("%f %f", 42, 43), "42 43");
assertEquals(stringify("%f %f", 42), "42 %f");
});