foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-21 23:04:45 -05:00
Code Issues Packages 1 Wiki Activity

📝 Update install instructions around known error (#110)

Browse source 
Even though the readme told me there was going to be an error, I was still confused about this error, as it looked unrelated to fetching the sources.

To clarify this update the readme to spell out the expected error.

Fixes #109
This commit is contained in:
Sam Saccone 2018-06-04 00:41:51 -07:00 committed by Ryan Dahl
parent 1e13a62f86
commit 8e211ea685
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
README.md
View file

@ -22,7 +22,7 @@ A secure TypeScript runtime on V8
code. Defaults to read-only file system access and no network access.
Access between V8 (unprivileged) and Golang (privileged) is only done via
serialized messages defined in this
[protobuf](https://github.com/ry/deno/blob/master/msg.proto), this makes it
[protobuf](https://github.com/ry/deno/blob/master/msg.proto), this makes it
easy to audit.
To enable write access explicitly use `--allow-write` and `--allow-net` for
network access.
@ -95,9 +95,16 @@ go get -u github.com/golang/protobuf/protoc-gen-go
go get -u github.com/jteeuwen/go-bindata/...
```
You need to get and build [v8worker2](https://github.com/ry/v8worker2). The package will not build with `go
get` and will log out an error, which can be ignored. It takes about 30 minutes
to build:
You need to get and build [v8worker2](https://github.com/ry/v8worker2). __The package will not build with `go
get` and will log out an error ⚠__
```bash
# pkg-config --cflags v8.pc
Failed to open 'v8.pc': No such file or directory
No package 'v8.pc' found
pkg-config: exit status 1
```
__which can be ignored__. It takes about 30 minutes to build:
``` bash
go get -u github.com/ry/v8worker2