From 8fe90d286160d6cc585e18b1a2f4e29bd1523852 Mon Sep 17 00:00:00 2001 From: David Sherret Date: Mon, 16 Sep 2024 22:23:40 +0100 Subject: [PATCH] fix(npm): better error handling for remote npm deps (#25670) * https://github.com/denoland/deno_npm/pull/68 --- Cargo.lock | 4 ++-- cli/Cargo.toml | 2 +- tests/specs/npm/dynamic_npm_resolution_failure/main.out | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Cargo.lock b/Cargo.lock index 6e3d80b3c1..a2636e2363 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1868,9 +1868,9 @@ dependencies = [ [[package]] name = "deno_npm" -version = "0.25.0" +version = "0.25.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "efb2dd7efaf478d780a6ca43e6127667d5329ed9a5ff89f42cec0dc21ee58342" +checksum = "e61b112e9bb332e8e6b0d82fcea7664423933de476e1726dd23a924a2d94f4ef" dependencies = [ "anyhow", "async-trait", diff --git a/cli/Cargo.toml b/cli/Cargo.toml index 216a1162e6..dda5a7a787 100644 --- a/cli/Cargo.toml +++ b/cli/Cargo.toml @@ -71,7 +71,7 @@ deno_doc = { version = "0.148.0", features = ["html", "syntect"] } deno_graph = { version = "=0.82.1" } deno_lint = { version = "=0.65.0", features = ["docs"] } deno_lockfile.workspace = true -deno_npm = "=0.25.0" +deno_npm = "=0.25.1" deno_package_json.workspace = true deno_runtime = { workspace = true, features = ["include_js_files_for_snapshotting"] } deno_semver.workspace = true diff --git a/tests/specs/npm/dynamic_npm_resolution_failure/main.out b/tests/specs/npm/dynamic_npm_resolution_failure/main.out index a795f0233a..d9eb7182fa 100644 --- a/tests/specs/npm/dynamic_npm_resolution_failure/main.out +++ b/tests/specs/npm/dynamic_npm_resolution_failure/main.out @@ -4,7 +4,7 @@ Download http://localhost:4260/@denotest/dep-cannot-parse [UNORDERED_END] Download http://localhost:4260/chalk/chalk-5.0.1.tgz Hi -TypeError: Error in @denotest/dep-cannot-parse@1.0.0 parsing version requirement for dependency: @denotest/esm-basic@unknown-scheme:unknown +TypeError: Error in @denotest/dep-cannot-parse@1.0.0 parsing version requirement for dependency "@denotest/esm-basic": "unknown-scheme:unknown" 0: Invalid version requirement 1: Unexpected character. unknown-scheme:unknown