foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-24 08:09:08 -05:00
Code Issues Packages 1 Wiki Activity

fix(ext/crypto): don't use core.decode for encoding jwk keys (#12088)

Browse source
This commit is contained in:
Divy Srivastava 2021-09-16 12:42:38 +05:30 committed by GitHub
parent 3c97dbf06b
commit 9270cad67c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
cli/tests/unit/webcrypto_test.ts
View file

@ -357,6 +357,30 @@ unitTest(async function subtleCryptoHmacImportExport() {
assertEquals(exportedKey2, jwk);
});
// https://github.com/denoland/deno/issues/12085
unitTest(async function generateImportHmacJwk() {
const key = await crypto.subtle.generateKey(
{
name: "HMAC",
hash: "SHA-512",
},
true,
["sign"],
);
assert(key);
assertEquals(key.type, "secret");
assertEquals(key.extractable, true);
assertEquals(key.usages, ["sign"]);
const exportedKey = await crypto.subtle.exportKey("jwk", key);
assertEquals(exportedKey.kty, "oct");
assertEquals(exportedKey.alg, "HS512");
assertEquals(exportedKey.key_ops, ["sign"]);
assertEquals(exportedKey.ext, true);
assert(typeof exportedKey.k == "string");
assertEquals(exportedKey.k.length, 171);
});
// 2048-bits publicExponent=65537
const pkcs8TestVectors = [
// rsaEncryption

7
ext/crypto/00_crypto.js
View file

@ -24,6 +24,7 @@
StringPrototypeToUpperCase,
StringPrototypeReplace,
StringPrototypeCharCodeAt,
StringFromCharCode,
Symbol,
SymbolFor,
SymbolToStringTag,
@ -140,9 +141,11 @@
}
function unpaddedBase64(bytes) {
const binaryString = core.decode(bytes);
let binaryString = "";
for (let i = 0; i < bytes.length; i++) {
binaryString += StringFromCharCode(bytes[i]);
}
const base64String = btoa(binaryString);
return StringPrototypeReplace(base64String, /=/g, "");
}