foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-24 08:09:08 -05:00
Code Issues Packages 1 Wiki Activity

fix: handle signal 0 in process.kill (#23473)

Browse source 
the last commit had a regression, where it removed this branch, I
haven't tested the code but I think it should work

---------

Signed-off-by: Bedis Nbiba <bedisnbiba@gmail.com>
This commit is contained in:
Bedis Nbiba 2024-05-19 19:52:03 +01:00 committed by GitHub
parent 9e890399fc
commit 927cbb5ecd
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ext/node/polyfills/process.ts
View file

@ -259,6 +259,10 @@ memoryUsage.rss = function (): number {
// Returns a negative error code than can be recognized by errnoException // Returns a negative error code than can be recognized by errnoException
function _kill(pid: number, sig: number): number { function _kill(pid: number, sig: number): number {
// signal 0 does not exist in constants.os.signals, thats why it have to be handled explicitly
if (sig === 0) {
return op_node_process_kill(pid, 0);
}
const maybeSignal = Object.entries(constants.os.signals).find(( const maybeSignal = Object.entries(constants.os.signals).find((
[_, numericCode], [_, numericCode],
) => numericCode === sig); ) => numericCode === sig);

5
tests/unit_node/process_test.ts
View file

@ -243,6 +243,11 @@ Deno.test(
args: ["eval", "setTimeout(() => {}, 10000)"], args: ["eval", "setTimeout(() => {}, 10000)"],
}).spawn(); }).spawn();
// kill with signal 0 should keep the process alive in linux (true means no error happened)
// windows ignore signals
if (Deno.build.os !== "windows") {
assertEquals(process.kill(p.pid, 0), true);
}
process.kill(p.pid); process.kill(p.pid);
await p.status; await p.status;
}, },