foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-11 08:33:43 -05:00
Code Issues Packages 1 Wiki Activity

fix(std/encoding/toml): Stop TOML parser from detecting numbers in strings. (#7064)

Browse source 
Before this patch the TOML parser would incorrect treat the string
"base64data0xdamaged" in a declaration as a hex number because the
corresponding check triggers even when the "0x" is inside a double
quoted string literal as long as it is followed by at least one hex
character.
This commit is contained in:
danielwippermann 2020-08-17 23:48:15 +02:00 committed by GitHub
parent 95a6812e82
commit 93e2bfe22e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
std/encoding/testdata/string.toml vendored
View file

@ -31,3 +31,4 @@ trimmed in raw strings.
withApostrophe = "What if it's not?"
withSemicolon = "const message = 'hello world';"
withHexNumberLiteral = "Prevent bug from stripping string here ->0xabcdef"

2
std/encoding/toml.ts
View file

@ -218,7 +218,7 @@ class Parser {
}
// If binary / octal / hex
const hex = /(0(?:x|o|b)[0-9a-f_]*)[^#]/gi.exec(dataString);
const hex = /^(0(?:x|o|b)[0-9a-f_]*)[^#]/gi.exec(dataString);
if (hex && hex[0]) {
return hex[0].trim();
}

2
std/encoding/toml_test.ts
View file

@ -29,6 +29,8 @@ Deno.test({
"whitespace\n is preserved.",
withApostrophe: "What if it's not?",
withSemicolon: `const message = 'hello world';`,
withHexNumberLiteral:
"Prevent bug from stripping string here ->0xabcdef",
},
};
const actual = parseFile(path.join(testFilesDir, "string.toml"));