foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-28 16:20:57 -05:00
Code Issues Packages 1 Wiki Activity

tests: disable another flaky test (#18762)

Browse source 
This test is flaky too, it actually shouldn't be running since it's not
listed in `cli/tests/node_compat/config.jsonc` at all.
This commit is contained in:
Bartek Iwańczuk 2023-04-19 02:10:01 +02:00 committed by GitHub
parent 40e157c005
commit 972469d309
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 63 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/tests/node_compat/config.jsonc
View file

@ -30,7 +30,8 @@
"test-child-process-exec-kill-throws.js", "test-child-process-exec-kill-throws.js",
"test-child-process-exec-maxbuf.js", "test-child-process-exec-maxbuf.js",
"test-child-process-exec-std-encoding.js", "test-child-process-exec-std-encoding.js",
"test-child-process-exec-timeout-expire.js", // TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-exec-timeout-expire.js",
"test-child-process-exec-timeout-kill.js", "test-child-process-exec-timeout-kill.js",
"test-child-process-exec-timeout-not-expired.js", "test-child-process-exec-timeout-not-expired.js",
"test-child-process-execFile-promisified-abortController.js", "test-child-process-execFile-promisified-abortController.js",
@ -209,7 +210,8 @@
"test-child-process-exec-kill-throws.js", "test-child-process-exec-kill-throws.js",
"test-child-process-exec-maxbuf.js", "test-child-process-exec-maxbuf.js",
"test-child-process-exec-stdout-stderr-data-string.js", "test-child-process-exec-stdout-stderr-data-string.js",
"test-child-process-exec-timeout-expire.js", // TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-exec-timeout-expire.js",
"test-child-process-exec-timeout-kill.js", "test-child-process-exec-timeout-kill.js",
// TODO(bartlomieju): this test was flaky on macOS CI // TODO(bartlomieju): this test was flaky on macOS CI
// "test-child-process-execFile-promisified-abortController.js", // "test-child-process-execFile-promisified-abortController.js",

61
cli/tests/node_compat/test/parallel/test-child-process-exec-timeout-expire.js
View file

@ -1,61 +0,0 @@
// deno-fmt-ignore-file
// deno-lint-ignore-file
// Copyright Joyent and Node contributors. All rights reserved. MIT license.
// Taken from Node 18.12.1
// This file is automatically generated by "node/_tools/setup.ts". Do not modify this file manually
// TODO(PolarETech): The process.argv[3] check should be argv[2], and the
// command passed to exec() should not need to include "run", "-A",
// and "require.ts".
'use strict';
// Test exec() with a timeout that expires.
const common = require('../common');
const assert = require('assert');
const cp = require('child_process');
const {
cleanupStaleProcess,
logAfterTime,
kExpiringChildRunTime,
kExpiringParentTimer
} = require('../common/child_process');
if (process.argv[3] === 'child') {
logAfterTime(kExpiringChildRunTime);
return;
}
const cmd = `"${process.execPath}" run -A require.ts "${__filename}" child`;
cp.exec(cmd, {
timeout: kExpiringParentTimer,
}, common.mustCall((err, stdout, stderr) => {
console.log('[stdout]', stdout.trim());
console.log('[stderr]', stderr.trim());
let sigterm = 'SIGTERM';
assert.strictEqual(err.killed, true);
// TODO OpenBSD returns a null signal and 143 for code
if (common.isOpenBSD) {
assert.strictEqual(err.code, 143);
sigterm = null;
} else {
assert.strictEqual(err.code, null);
}
// At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a
// process that is still starting up kills it with SIGKILL instead of SIGTERM.
// See: https://github.com/libuv/libuv/issues/1226
if (common.isOSX)
assert.ok(err.signal === 'SIGTERM' || err.signal === 'SIGKILL');
else
assert.strictEqual(err.signal, sigterm);
assert.strictEqual(err.cmd, cmd);
assert.strictEqual(stdout.trim(), '');
assert.strictEqual(stderr.trim(), '');
}));
cleanupStaleProcess(__filename);