foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity

Fix error handling in deno::ReadFileToString

Browse source 
Starts a unit test for it, and adds to mock_runtime_test.
This commit is contained in:
Ryan Dahl 2018-06-15 15:45:45 +02:00
parent b2694ecbd8
commit 97923e3d26
3 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
deno2/BUILD.gn
View file

@ -17,6 +17,7 @@ executable("deno") {
executable("mock_runtime_test") {
testonly = true
sources = [
"file_util_test.cc",
"from_snapshot.cc",
"mock_runtime_test.cc",
]

5
deno2/file_util.cc
View file

@ -11,8 +11,11 @@ namespace deno {
bool ReadFileToString(const char* fn, std::string* contents) {
std::ifstream file(fn, std::ios::binary);
if (file.fail()) {
return false;
}
contents->assign(std::istreambuf_iterator<char>{file}, {});
return !file.bad();
return !file.fail();
}
class StartupDataCppWriter {

13
deno2/file_util_test.cc Normal file
View file

@ -0,0 +1,13 @@
// Copyright 2018 Ryan Dahl <ry@tinyclouds.org>
// All rights reserved. MIT License.
#include "testing/gtest/include/gtest/gtest.h"
#include "file_util.h"
TEST(FileUtilTest, ReadFileToStringFileNotExist) {
std::string output;
EXPECT_FALSE(deno::ReadFileToString("/should_error_out.txt", &output));
}
// TODO(ry) success unit test. Needs a tempfile or fixture.
// TEST(FileUtilTest, ReadFileToStringSuccess) { }