From 97b8c9be3897f2a17439b217d1cd9884c39c087f Mon Sep 17 00:00:00 2001 From: Ian Bull Date: Tue, 17 Sep 2024 15:32:12 -0700 Subject: [PATCH] refactor(ext/websocket): align error messages (#25622) Aligns the error messages in the ext/websocket folder to be in-line with the Deno style guide. https://github.com/denoland/deno/issues/25269 --- ext/websocket/01_websocket.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ext/websocket/01_websocket.js b/ext/websocket/01_websocket.js index c55685ac93..58f4773101 100644 --- a/ext/websocket/01_websocket.js +++ b/ext/websocket/01_websocket.js @@ -161,14 +161,14 @@ class WebSocket extends EventTarget { if (wsURL.protocol !== "ws:" && wsURL.protocol !== "wss:") { throw new DOMException( - "Only ws & wss schemes are allowed in a WebSocket URL.", + `Only ws & wss schemes are allowed in a WebSocket URL: received ${wsURL.protocol}`, "SyntaxError", ); } if (wsURL.hash !== "" || StringPrototypeEndsWith(wsURL.href, "#")) { throw new DOMException( - "Fragments are not allowed in a WebSocket URL.", + "Fragments are not allowed in a WebSocket URL", "SyntaxError", ); } @@ -195,7 +195,7 @@ class WebSocket extends EventTarget { ) ) { throw new DOMException( - "Can't supply multiple times the same protocol.", + "Cannot supply multiple times the same protocol", "SyntaxError", ); } @@ -208,7 +208,7 @@ class WebSocket extends EventTarget { ) ) { throw new DOMException( - "Invalid protocol value.", + "Invalid protocol value", "SyntaxError", ); } @@ -330,7 +330,7 @@ class WebSocket extends EventTarget { data = webidl.converters.WebSocketSend(data, prefix, "Argument 1"); if (this[_readyState] !== OPEN) { - throw new DOMException("readyState not OPEN", "InvalidStateError"); + throw new DOMException("'readyState' not OPEN", "InvalidStateError"); } if (this[_sendQueue].length === 0) { @@ -376,7 +376,7 @@ class WebSocket extends EventTarget { !(code === 1000 || (3000 <= code && code < 5000)) ) { throw new DOMException( - "The close code must be either 1000 or in the range of 3000 to 4999.", + `The close code must be either 1000 or in the range of 3000 to 4999: received ${code}`, "InvalidAccessError", ); } @@ -387,7 +387,7 @@ class WebSocket extends EventTarget { TypedArrayPrototypeGetByteLength(core.encode(reason)) > 123 ) { throw new DOMException( - "The close reason may not be longer than 123 bytes.", + "The close reason may not be longer than 123 bytes", "SyntaxError", ); }