fix(publish): do not warn about excluded external modules in node_modules directory (#23173)

cli/tools/registry/mod.rs

@@ -212,8 +212,15 @@ fn collect_excluded_module_diagnostics(
     return;
   };
   let specifiers = graph
-    .specifiers()
+    .modules()
-    .map(|(s, _)| s)
+    .filter_map(|m| match m {
+      deno_graph::Module::Js(_) | deno_graph::Module::Json(_) => {
+        Some(m.specifier())
+      }
+      deno_graph::Module::Npm(_)
+      | deno_graph::Module::Node(_)
+      | deno_graph::Module::External(_) => None,
+    })
     .filter(|s| s.as_str().starts_with(root.as_str()));
   for specifier in specifiers {
     if !file_patterns.matches_specifier(specifier) {

tests/specs/publish/byonm_dep/__test__.jsonc

@@ -0,0 +1,4 @@
+{
+  "args": "publish --dry-run --allow-dirty",
+  "output": "publish.out"
+}

tests/specs/publish/byonm_dep/deno.jsonc

@@ -0,0 +1,11 @@
+{
+  "name": "@scope/package",
+  "version": "0.0.0",
+  "exports": "./mod.ts",
+  "publish": {
+    // this was previously causing issues because it would cause
+    // external modules in the node_modules directory to be ignored
+    "include": ["mod.ts"]
+  },
+  "unstable": ["byonm", "sloppy-imports"]
+}

tests/specs/publish/byonm_dep/mod.ts

@@ -0,0 +1,7 @@
+import { add } from "package";
+
+export function myAdd(a: number, b: number): number {
+  return add(a, b);
+}
+
+export { add };

tests/specs/publish/byonm_dep/node_modules/package/index.d.ts

@@ -0,0 +1 @@
+export function add(a: number, b: number): number;

tests/specs/publish/byonm_dep/node_modules/package/index.js

@@ -0,0 +1,3 @@
+export function add(a, b) {
+  return a + b;
+}

tests/specs/publish/byonm_dep/node_modules/package/package.json

@@ -0,0 +1,4 @@
+{
+  "main": "index.js",
+  "type": "module"
+}

tests/specs/publish/byonm_dep/package.json

@@ -0,0 +1,5 @@
+{
+  "dependencies": {
+    "package": "*"
+  }
+}

tests/specs/publish/byonm_dep/publish.out

@@ -0,0 +1,6 @@
+Check file:///[WILDLINE]/mod.ts
+Checking for slow types in the public API...
+Check file:///[WILDLINE]/mod.ts
+Simulating publish of @scope/package@0.0.0 with files:
+   file:///[WILDLINE]/mod.ts (129B)
+Warning Aborting due to --dry-run