foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

fix(lsp): less agressive completion triggers (#17225)

Browse source 
Closes https://github.com/denoland/deno/issues/17056
Closes https://github.com/denoland/deno/issues/17055
This commit is contained in:
Bartek Iwańczuk 2022-12-30 14:11:50 +01:00 committed by GitHub
parent 218d7ab778
commit 98bbf87742
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cli/lsp/tsc.rs
View file

@ -2007,6 +2007,10 @@ impl CompletionEntryDetails {
documentation,
command,
additional_text_edits,
// NOTE(bartlomieju): it's not entirely clear to me why we need to do that,
// but when `completionItem/resolve` is called, we get a list of commit chars
// even though we might have returned an empty list in `completion` request.
commit_characters: None,
..original_item.clone()
})
}

14
cli/tests/lsp_tests.rs
View file

@ -3958,12 +3958,6 @@ export class DuckConfig {
},
"newText": "import { foo } from \"./b.ts\";\n\n"
}
],
"commitCharacters": [
".",
",",
";",
"("
]
}))
);
@ -4077,13 +4071,7 @@ export class DuckConfig {
"sortText": "11",
"filterText": "type=\"$1\"",
"insertText": "type=\"$1\"",
"insertTextFormat": 2,
"commitCharacters": [
".",
",",
";",
"("
]
"insertTextFormat": 2
}))
);
}