1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00

fix: allow WPT to successfully exit using --exit-zero (#23418)

I went with `--exit-zero`. Happy to change to `--no-exit` if feelings
are strong.

Supercedes #23417
This commit is contained in:
Asher Gomez 2024-04-17 20:40:47 +10:00 committed by GitHub
parent ebc22d9d7e
commit 9acbf90b06
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 1 deletions

View file

@ -72,7 +72,7 @@ jobs:
deno run --unstable --allow-write --allow-read --allow-net \
--allow-env --allow-run --lock=tools/deno.lock.json \
./tests/wpt/wpt.ts run \ \
--binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json
--binary=$(which deno) --quiet --release --no-ignore --json=wpt.json --wptreport=wptreport.json --exit-zero
- name: Upload wpt results to wpt.fyi
env:

View file

@ -550,6 +550,12 @@ function reportFinal(
}. ${finalPassedCount} passed; ${finalFailedCount} failed; ${finalExpectedFailedAndFailedCount} expected failure; total ${finalTotalCount} (${duration}ms)\n`,
);
// We ignore the exit code of the test run because the CI job reports the
// results to WPT.fyi, and we still want to report failure.
if (Deno.args.includes("--exit-zero")) {
return 0;
}
return failed ? 1 : 0;
}