test(ext/node): added unit test for net node modules compat from std (#19663)

cli/tests/integration/node_unit_tests.rs

@@ -66,6 +66,7 @@ util::unit_test_factory!(
     pbkdf2_test = internal / pbkdf2_test,
     scrypt_test = internal / scrypt_test,
     module_test,
+    net_test,
     os_test,
     process_test,
     querystring_test,

cli/tests/unit_node/net_test.ts

@@ -0,0 +1,98 @@
+// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.
+
+import * as net from "node:net";
+import { assertEquals } from "../../../test_util/std/testing/asserts.ts";
+import { deferred } from "../../../test_util/std/async/deferred.ts";
+import * as path from "../../../test_util/std/path/mod.ts";
+import * as http from "node:http";
+import { assert } from "../../../test_util/std/testing/asserts.ts";
+
+Deno.test("[node/net] close event emits after error event", async () => {
+  const socket = net.createConnection(27009, "doesnotexist");
+  const events: ("error" | "close")[] = [];
+  const errorEmitted = deferred();
+  const closeEmitted = deferred();
+  socket.once("error", () => {
+    events.push("error");
+    errorEmitted.resolve();
+  });
+  socket.once("close", () => {
+    events.push("close");
+    closeEmitted.resolve();
+  });
+  await Promise.all([errorEmitted, closeEmitted]);
+
+  // `error` happens before `close`
+  assertEquals(events, ["error", "close"]);
+});
+
+Deno.test("[node/net] the port is available immediately after close callback", async () => {
+  const p = deferred();
+
+  // This simulates what get-port@5.1.1 does.
+  const getAvailablePort = (port: number) =>
+    new Promise((resolve, reject) => {
+      const server = net.createServer();
+      server.on("error", reject);
+      server.listen({ port }, () => {
+        // deno-lint-ignore no-explicit-any
+        const { port } = server.address() as any;
+        server.close(() => {
+          resolve(port);
+        });
+      });
+    });
+
+  const port = await getAvailablePort(5555);
+
+  const httpServer = http.createServer();
+  httpServer.on("error", (e) => p.reject(e));
+  httpServer.listen(port, () => {
+    httpServer.close(() => p.resolve());
+  });
+  await p;
+});
+
+Deno.test("[node/net] net.connect().unref() works", async () => {
+  const ctl = new AbortController();
+  const server = Deno.serve({
+    signal: ctl.signal,
+    handler: () => new Response("hello"),
+    onListen: async ({ port, hostname }) => {
+      const { stdout, stderr } = await new Deno.Command(Deno.execPath(), {
+        args: [
+          "eval",
+          `
+            import * as net from "node:net";
+            const socket = net.connect(${port}, "${hostname}", () => {
+              console.log("connected");
+              socket.unref();
+              socket.on("data", (data) => console.log(data.toString()));
+              socket.write("GET / HTTP/1.1\\n\\n");
+            });
+          `,
+        ],
+        cwd: path.dirname(path.fromFileUrl(import.meta.url)),
+      }).output();
+      if (stderr.length > 0) {
+        console.log(new TextDecoder().decode(stderr));
+      }
+      assertEquals(new TextDecoder().decode(stdout), "connected\n");
+      ctl.abort();
+    },
+  });
+  await server.finished;
+});
+
+Deno.test({
+  name: "[node/net] throws permission error instead of unknown error",
+  permissions: "none",
+  fn: () => {
+    try {
+      const s = new net.Server();
+      s.listen(3000);
+    } catch (e) {
+      assert(e instanceof Deno.errors.PermissionDenied);
+    }
+  },
+});