foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-29 16:30:56 -05:00
Code Issues Packages 1 Wiki Activity

fix(op_crates/web): TextEncoder should return error message with original input (#8005)

Browse source
This commit is contained in:
aca 2020-10-20 20:47:38 +09:00 committed by GitHub
parent d9ae74019e
commit 9cf06f76fd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
cli/tests/unit/text_encoding_test.ts
View file

@ -104,10 +104,10 @@ unitTest(function textDecoderASCII(): void {
unitTest(function textDecoderErrorEncoding(): void {
let didThrow = false;
try {
new TextDecoder("foo");
new TextDecoder("Foo");
} catch (e) {
didThrow = true;
assertEquals(e.message, "The encoding label provided ('foo') is invalid.");
assertEquals(e.message, "The encoding label provided ('Foo') is invalid.");
}
assert(didThrow);
});

4
op_crates/web/08_text_encoding.js
View file

@ -973,8 +973,8 @@
if (options.fatal) {
this.fatal = true;
}
label = String(label).trim().toLowerCase();
const encoding = encodings.get(label);
const _label = String(label).trim().toLowerCase();
const encoding = encodings.get(_label);
if (!encoding) {
throw new RangeError(
`The encoding label provided ('${label}') is invalid.`,

4
op_crates/web/text_encoding_test.js
View file

@ -163,10 +163,10 @@ function textDecoderASCII() {
function textDecoderErrorEncoding() {
let didThrow = false;
try {
new TextDecoder("foo");
new TextDecoder("Foo");
} catch (e) {
didThrow = true;
assert(e.message === "The encoding label provided ('foo') is invalid.");
assert(e.message === "The encoding label provided ('Foo') is invalid.");
}
assert(didThrow);
}