foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-29 02:29:06 -05:00
Code Issues Packages 1 Wiki Activity

Avoid textproto crashing on empty reader (#50)

Browse source
This commit is contained in:
Kevin (Kun) "Kassimo" Qian 2018-12-31 04:00:28 -05:00 committed by Ryan Dahl
parent 9b8923844f
commit 9eb6aa5fd9
2 changed files with 10 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
net/textproto.ts
View file

@ -118,11 +118,12 @@ export class TextProtoReader {
async readLineSlice(): Promise<[Uint8Array, BufState]> {
// this.closeDot();
let line: null | Uint8Array;
let line: Uint8Array;
while (true) {
let [l, more, err] = await this.r.readLine();
if (err != null) {
return [null, err];
// Go's len(typed nil) works fine, but not in JS
return [new Uint8Array(0), err];
}
// Avoid the copy if the first call produced a full line.
if (line == null && !more) {

7
net/textproto_test.ts
View file

@ -93,3 +93,10 @@ test(async function textprotoAppend() {
const joined = append(u1, u2);
assertEqual(dec.decode(joined), "Hello World");
});
test(async function textprotoReadEmpty() {
let r = reader("");
let [m, err] = await r.readMIMEHeader();
// Should not crash!
assertEqual(err, "EOF");
});