foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

fix(compile): adhoc codesign mach-o by default (#24824)

Browse source
This commit is contained in:
Divy Srivastava 2024-08-01 02:11:24 -07:00 committed by GitHub
parent f1fc708d81
commit 9f27bf9144
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/standalone/binary.rs
View file

@ -183,7 +183,7 @@ fn write_binary_bytes(
} else if target.contains("darwin") {
libsui::Macho::from(original_bin)?
.write_section("d3n0l4nd", writer)?
.build(&mut file_writer)?;
.build_and_sign(&mut file_writer)?;
}
Ok(())
}
@ -194,8 +194,8 @@ pub fn is_standalone_binary(exe_path: &Path) -> bool {
};
libsui::utils::is_elf(&data)
| libsui::utils::is_pe(&data)
| libsui::utils::is_macho(&data)
|| libsui::utils::is_pe(&data)
|| libsui::utils::is_macho(&data)
}
/// This function will try to run this binary as a standalone binary

11
tests/integration/compile_tests.rs
View file

@ -34,6 +34,17 @@ fn compile_basic() {
output.assert_matches_text("Welcome to Deno!\n");
}
// On arm64 macOS, check if `codesign -v` passes
#[cfg(all(target_os = "macos", target_arch = "aarch64"))]
{
let output = std::process::Command::new("codesign")
.arg("-v")
.arg(&exe)
.output()
.unwrap();
assert!(output.status.success());
}
// now ensure this works when the deno_dir is readonly
let readonly_dir = dir.path().join("readonly");
readonly_dir.make_dir_readonly();