foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-22 15:06:54 -05:00
Code Issues Packages 1 Wiki Activity

perf: optimize ByteString checks, hoist server rid getter (#19452)

Browse source 
Further improves preact SSR and express benches by about 2k RPS.

Ref https://github.com/denoland/deno/issues/19451
This commit is contained in:
Bartek Iwańczuk 2023-06-10 00:45:56 +02:00
parent f7cb0b44e3
commit a0a7a65cc3
No known key found for this signature in database
GPG key ID: 0C6BCDDC3B3AD750
2 changed files with 12 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
ext/http/00_serve.js
View file

@ -682,8 +682,8 @@ function serveHttpOn(context, callback) {
// Run the server // Run the server
const finished = (async () => { const finished = (async () => {
const rid = context.serverRid;
while (true) { while (true) {
const rid = context.serverRid;
let req; let req;
try { try {
// Attempt to pull as many requests out of the queue as possible before awaiting. This API is // Attempt to pull as many requests out of the queue as possible before awaiting. This API is

15
ext/webidl/00_webidl.js
View file

@ -59,7 +59,6 @@ const {
ReflectHas, ReflectHas,
ReflectOwnKeys, ReflectOwnKeys,
RegExpPrototypeTest, RegExpPrototypeTest,
RegExpPrototypeExec,
SafeRegExp, SafeRegExp,
SafeSet, SafeSet,
SetPrototypeEntries, SetPrototypeEntries,
@ -403,11 +402,19 @@ converters.DOMString = function (V, prefix, context, opts = {}) {
return String(V); return String(V);
}; };
// deno-lint-ignore no-control-regex function isByteString(input) {
const IS_BYTE_STRING = new SafeRegExp(/^[\x00-\xFF]*$/); for (let i = 0; i < input.length; i++) {
if (StringPrototypeCharCodeAt(input, i) > 255) {
// If a character code is greater than 255, it means the string is not a byte string.
return false;
}
}
return true;
}
converters.ByteString = (V, prefix, context, opts) => { converters.ByteString = (V, prefix, context, opts) => {
const x = converters.DOMString(V, prefix, context, opts); const x = converters.DOMString(V, prefix, context, opts);
if (RegExpPrototypeExec(IS_BYTE_STRING, x) === null) { if (!isByteString(x)) {
throw makeException( throw makeException(
TypeError, TypeError,
"is not a valid ByteString", "is not a valid ByteString",