foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-26 16:09:27 -05:00
Code Issues Packages 1 Wiki Activity

test(cli): fix brittle network permission test (#8526)

Browse source
This commit is contained in:
William Perron 2020-11-27 15:02:25 -05:00 committed by GitHub
parent e2858d0bbb
commit a16adca06b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
cli/tests/unit/net_test.ts
View file

@ -68,7 +68,7 @@ unitTest(
unitTest( unitTest(
{ ignore: Deno.build.os === "windows", perms: { read: true } }, { ignore: Deno.build.os === "windows", perms: { read: true } },
function netUnixListenWritePermission(): void { function netUnixListenWritePermission(): void {
try { assertThrows(() => {
const filePath = Deno.makeTempFileSync(); const filePath = Deno.makeTempFileSync();
const socket = Deno.listen({ const socket = Deno.listen({
path: filePath, path: filePath,
@ -77,17 +77,14 @@ unitTest(
assert(socket.addr.transport === "unix"); assert(socket.addr.transport === "unix");
assertEquals(socket.addr.path, filePath); assertEquals(socket.addr.path, filePath);
socket.close(); socket.close();
} catch (e) { }, Deno.errors.PermissionDenied);
assert(!!e);
assert(e instanceof Deno.errors.PermissionDenied);
}
}, },
); );
unitTest( unitTest(
{ ignore: Deno.build.os === "windows", perms: { read: true } }, { ignore: Deno.build.os === "windows", perms: { read: true } },
function netUnixPacketListenWritePermission(): void { function netUnixPacketListenWritePermission(): void {
try { assertThrows(() => {
const filePath = Deno.makeTempFileSync(); const filePath = Deno.makeTempFileSync();
const socket = Deno.listenDatagram({ const socket = Deno.listenDatagram({
path: filePath, path: filePath,
@ -96,10 +93,7 @@ unitTest(
assert(socket.addr.transport === "unixpacket"); assert(socket.addr.transport === "unixpacket");
assertEquals(socket.addr.path, filePath); assertEquals(socket.addr.path, filePath);
socket.close(); socket.close();
} catch (e) { }, Deno.errors.PermissionDenied);
assert(!!e);
assert(e instanceof Deno.errors.PermissionDenied);
}
}, },
); );