foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity

fix(cli/lint): don't use gray in diagnostics output for visibility (#11702)

Browse source
This commit is contained in:
Yusuke Tanaka 2021-08-14 22:05:07 +09:00 committed by GitHub
parent c87b13e745
commit a1c5fef67f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 19 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
cli/tools/lint.rs
View file

@ -229,8 +229,7 @@ impl LintReporter for PrettyLintReporter {
fn visit_diagnostic(&mut self, d: &LintDiagnostic, source_lines: Vec<&str>) {
self.lint_count += 1;
let pretty_message =
format!("({}) {}", colors::gray(&d.code), d.message.clone());
let pretty_message = format!("({}) {}", colors::red(&d.code), &d.message);
let message = format_diagnostic(
&d.code,
@ -302,27 +301,25 @@ pub fn format_diagnostic(
}
}
if let Some(hint) = maybe_hint {
format!(
"{}\n{}\n at {}\n\n {} {}\n {} for further information visit https://lint.deno.land/#{}",
message_line,
lines.join("\n"),
formatted_location,
colors::gray("hint:"),
hint,
colors::gray("help:"),
diagnostic_code,
)
let hint = if let Some(hint) = maybe_hint {
format!(" {} {}\n", colors::cyan("hint:"), hint)
} else {
format!(
"{}\n{}\n at {}\n\n {} for further information visit https://lint.deno.land/#{}",
message_line,
lines.join("\n"),
formatted_location,
colors::gray("help:"),
diagnostic_code,
)
}
"".to_string()
};
let help = format!(
" {} for further information visit https://lint.deno.land/#{}",
colors::cyan("help:"),
diagnostic_code
);
format!(
"{message_line}\n{snippets}\n at {formatted_location}\n\n{hint}{help}",
message_line = message_line,
snippets = lines.join("\n"),
formatted_location = formatted_location,
hint = hint,
help = help
)
}
#[derive(Serialize)]