foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-24 15:19:26 -05:00
Code Issues Packages 1 Wiki Activity

fix(cli): make signals tests more reliable (#21772)

Browse source 
Delivering POSIX signals too quickly may result in signal coalescing.
This commit is contained in:
Matt Mastracci 2024-01-03 07:41:58 -07:00 committed by GitHub
parent f5ad15b504
commit a387efa46e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 40 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

57
cli/tests/unit/signal_test.ts
View file

@ -110,27 +110,25 @@ Deno.test(
permissions: { run: true },
},
async function signalListenerTest() {
const { promise, resolve } = Promise.withResolvers<void>();
let c = 0;
const listener = () => {
c += 1;
};
// This test needs to be careful that it doesn't accidentally aggregate multiple
// signals into one. Sending two or more SIGxxx before the handler can be run will
// result in signal coalescing.
Deno.addSignalListener("SIGUSR1", listener);
setTimeout(async () => {
// Sends SIGUSR1 3 times.
for (const _ of Array(3)) {
await delay(20);
for (let i = 1; i <= 3; i++) {
await delay(1);
Deno.kill(Deno.pid, "SIGUSR1");
}
await promise;
Deno.removeSignalListener("SIGUSR1", listener);
});
// We'll get three signals eventually
while (c < 3) {
while (c < i) {
await delay(20);
}
resolve();
}
Deno.removeSignalListener("SIGUSR1", listener);
await delay(100);
assertEquals(c, 3);
},
);
@ -140,7 +138,6 @@ Deno.test(
permissions: { run: true },
},
async function multipleSignalListenerTest() {
const { promise, resolve } = Promise.withResolvers<void>();
let c = "";
const listener0 = () => {
c += "0";
@ -148,39 +145,45 @@ Deno.test(
const listener1 = () => {
c += "1";
};
// This test needs to be careful that it doesn't accidentally aggregate multiple
// signals into one. Sending two or more SIGxxx before the handler can be run will
// result in signal coalescing.
Deno.addSignalListener("SIGUSR2", listener0);
Deno.addSignalListener("SIGUSR2", listener1);
setTimeout(async () => {
// Sends SIGUSR2 3 times.
for (const _ of Array(3)) {
await delay(20);
for (let i = 1; i <= 3; i++) {
await delay(1);
Deno.kill(Deno.pid, "SIGUSR2");
}
while (c.length < 6) {
while (c.length < i * 2) {
await delay(20);
}
}
Deno.removeSignalListener("SIGUSR2", listener1);
// Sends SIGUSR2 3 times.
for (const _ of Array(3)) {
await delay(20);
for (let i = 1; i <= 3; i++) {
await delay(1);
Deno.kill(Deno.pid, "SIGUSR2");
}
while (c.length < 6 + i) {
await delay(20);
}
}
// Sends SIGUSR1 (irrelevant signal) 3 times.
for (const _ of Array(3)) {
await delay(20);
Deno.kill(Deno.pid, "SIGUSR1");
}
while (c.length < 9) {
await delay(20);
}
// No change
assertEquals(c, "010101000");
Deno.removeSignalListener("SIGUSR2", listener0);
resolve();
});
await promise;
await delay(100);
// The first 3 events are handled by both handlers
// The last 3 events are handled only by handler0
assertEquals(c, "010101000");