foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

fix(op_crate/fetch): infinite loop on fill headers (#10406)

Browse source 
Fixes a pesky bug in the fetch implementation where if the init part is
specified in `fetch` instead of the `Request` constructor, the
fillHeaders function receives two references to the same object, causing
it to append to the same list being iterated over.
This commit is contained in:
William Perron 2021-04-29 13:56:59 -04:00 committed by GitHub
parent 0ac2a17a0f
commit a50dab683f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
cli/tests/unit/fetch_test.ts
View file

@ -447,6 +447,21 @@ unitTest(
},
);
unitTest(
{ perms: { net: true } },
async function fetchSeparateInit(): Promise<void> {
// related to: https://github.com/denoland/deno/issues/10396
const req = new Request("http://localhost:4545/cli/tests/001_hello.js");
const init = {
method: "GET",
};
req.headers.set("foo", "bar");
const res = await fetch(req, init);
assertEquals(res.status, 200);
await res.text();
},
);
unitTest(
{ perms: { net: true } },
async function fetchInitTypedArrayBody(): Promise<void> {

7
op_crates/fetch/23_request.js
View file

@ -247,11 +247,14 @@
// 31.
if (Object.keys(init).length > 0) {
let headers = headerListFromHeaders(this[_headers]);
let headers = headerListFromHeaders(this[_headers]).slice(
0,
headerListFromHeaders(this[_headers]).length,
);
if (init.headers !== undefined) {
headers = init.headers;
}
headerListFromHeaders(this[_headers]).slice(
headerListFromHeaders(this[_headers]).splice(
0,
headerListFromHeaders(this[_headers]).length,
);