foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 23:34:47 -05:00
Code Issues Packages 1 Wiki Activity

chore(serde_v8): V8Slice SAFETY (#14493)

Browse source
This commit is contained in:
Aaron O'Mullan 2022-05-05 09:16:39 -03:00 committed by GitHub
parent 45a4d75296
commit a58afc098d
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
serde_v8/magic/v8slice.rs
View file

@ -41,12 +41,26 @@ impl V8Slice {
}
fn as_slice(&self) -> &[u8] {
// SAFETY: v8::SharedRef<v8::BackingStore> is similar to Arc<[u8]>,
// it points to a fixed continuous slice of bytes on the heap.
// We assume it's initialized and thus safe to read (though may not contain meaningful data)
unsafe { &*(&self.store[self.range.clone()] as *const _ as *const [u8]) }
}
#[allow(clippy::cast_ref_to_mut)]
fn as_slice_mut(&mut self) -> &mut [u8] {
unsafe { &mut *(&self.store[self.range.clone()] as *const _ as *mut [u8]) }
// SAFETY: v8::SharedRef<v8::BackingStore> is similar to Arc<[u8]>,
// it points to a fixed continuous slice of bytes on the heap.
// It's safe-ish to mutate concurrently because it can not be
// shrunk/grown/moved/reallocated, thus avoiding dangling refs (unlike a Vec).
// Concurrent writes can't lead to meaningful structural invalidation
// since we treat them as opaque buffers / "bags of bytes",
// concurrent mutation is simply an accepted fact of life.
// And in practice V8Slices also do not have overallping read/write phases.
// TLDR: permissive interior mutability on slices of bytes is "fine"
#[allow(clippy::cast_ref_to_mut)]
unsafe {
&mut *(&self.store[self.range.clone()] as *const _ as *mut [u8])
}
}
}