foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-29 16:30:56 -05:00
Code Issues Packages 1 Wiki Activity

fix urlSearchParams custom symbol iterator (#2537)

Browse source
This commit is contained in:
迷渡 2019-06-17 23:39:23 +08:00 committed by Ryan Dahl
parent 76329cf610
commit a953190742
2 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
js/url_search_params.ts
View file

@ -12,16 +12,11 @@ export class URLSearchParams {
return; return;
} }
if (Array.isArray(init)) { if (Array.isArray(init) || isIterable(init)) {
this._handleArrayInitialization(init); this._handleArrayInitialization(init);
return; return;
} }
if (isIterable(init)) {
this.params = [...init];
return;
}
if (Object(init) !== init) { if (Object(init) !== init) {
return; return;
} }
@ -285,7 +280,9 @@ export class URLSearchParams {
} }
} }
private _handleArrayInitialization(init: string[][]): void { private _handleArrayInitialization(
init: string[][] | Iterable<[string, string]>
): void {
// Overload: sequence<sequence<USVString>> // Overload: sequence<sequence<USVString>>
for (const tuple of init) { for (const tuple of init) {
// If pair does not contain exactly two items, then throw a TypeError. // If pair does not contain exactly two items, then throw a TypeError.

9
js/url_search_params_test.ts
View file

@ -227,3 +227,12 @@ test(function urlSearchParamsCustomSymbolIterator(): void {
const params1 = new URLSearchParams((params as unknown) as string[][]); const params1 = new URLSearchParams((params as unknown) as string[][]);
assertEquals(params1.get("a"), "b"); assertEquals(params1.get("a"), "b");
}); });
test(function urlSearchParamsCustomSymbolIteratorWithNonStringParams(): void {
const params = {};
params[Symbol.iterator] = function*(): IterableIterator<[number, number]> {
yield [1, 2];
};
const params1 = new URLSearchParams((params as unknown) as string[][]);
assertEquals(params1.get("1"), "2");
});