foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-25 15:29:32 -05:00
Code Issues Packages 1 Wiki Activity

fix timer's params length (#2655)

Browse source
This commit is contained in:
迷渡 2019-07-18 18:09:32 +08:00 committed by Ryan Dahl
parent a0b8f13f18
commit ac98bd8a7c
2 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
js/timers.ts
View file

@ -229,7 +229,7 @@ function setTimer(
/** Sets a timer which executes a function once after the timer expires. */ /** Sets a timer which executes a function once after the timer expires. */
export function setTimeout( export function setTimeout(
cb: (...args: Args) => void, cb: (...args: Args) => void,
delay: number, delay: number = 0,
...args: Args ...args: Args
): number { ): number {
// @ts-ignore // @ts-ignore
@ -240,7 +240,7 @@ export function setTimeout(
/** Repeatedly calls a function , with a fixed time delay between each call. */ /** Repeatedly calls a function , with a fixed time delay between each call. */
export function setInterval( export function setInterval(
cb: (...args: Args) => void, cb: (...args: Args) => void,
delay: number, delay: number = 0,
...args: Args ...args: Args
): number { ): number {
// @ts-ignore // @ts-ignore
@ -261,10 +261,16 @@ function clearTimer(id: number): void {
idMap.delete(timer.id); idMap.delete(timer.id);
} }
export function clearTimeout(id: number): void { export function clearTimeout(id: number = 0): void {
if (id === 0) {
return;
}
clearTimer(id); clearTimer(id);
} }
export function clearInterval(id: number): void { export function clearInterval(id: number = 0): void {
if (id === 0) {
return;
}
clearTimer(id); clearTimer(id);
} }

7
js/timers_test.ts
View file

@ -249,6 +249,13 @@ test(function testFunctionName(): void {
assertEquals(clearInterval.name, "clearInterval"); assertEquals(clearInterval.name, "clearInterval");
}); });
test(function testFunctionParamsLength(): void {
assertEquals(setTimeout.length, 1);
assertEquals(setInterval.length, 1);
assertEquals(clearTimeout.length, 0);
assertEquals(clearInterval.length, 0);
});
test(function clearTimeoutAndClearIntervalNotBeEquals(): void { test(function clearTimeoutAndClearIntervalNotBeEquals(): void {
assertNotEquals(clearTimeout, clearInterval); assertNotEquals(clearTimeout, clearInterval);
}); });