foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2025-01-07 22:58:24 -05:00
Code Issues Packages 1 Wiki Activity

modify test to avoid op leaks

Browse source
This commit is contained in:
Yoshiya Hinosawa 2024-11-12 20:59:04 +09:00
parent b276d38671
commit ace7f8bbd6
No known key found for this signature in database
GPG key ID: 9017DB4559488785
1 changed files with 18 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
tests/unit_node/http_test.ts
View file

@ -1075,22 +1075,33 @@ Deno.test("[node/https] node:https exports globalAgent", async () => {
); );
}); });
Deno.test("[node/http] node:http request.setHeader(header, null) doesn't throw", () => { Deno.test("[node/http] node:http request.setHeader(header, null) doesn't throw", async () => {
{ {
const req = http.request("http://localhost:4545/"); const { promise, resolve } = Promise.withResolvers<void>();
req.on("error", () => {}); const req = http.request("http://localhost:4545/", (res) => {
res.on("data", () => {});
res.on("end", () => {
resolve();
});
});
// @ts-expect-error - null is not a valid header value // @ts-expect-error - null is not a valid header value
req.setHeader("foo", null); req.setHeader("foo", null);
req.end(); req.end();
req.destroy(); await promise;
} }
{ {
const req = https.request("https://localhost:4545/"); const { promise, resolve } = Promise.withResolvers<void>();
req.on("error", () => {}); const req = http.request("http://localhost:4545/", (res) => {
res.on("data", () => {});
res.on("end", () => {
resolve();
});
});
// @ts-expect-error - null is not a valid header value // @ts-expect-error - null is not a valid header value
req.setHeader("foo", null); req.setHeader("foo", null);
req.end(); req.end();
req.destroy();
await promise;
} }
}); });