From ae0e7df41a15d584703f956f0e2dc91dab4aec38 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Tue, 16 Jan 2024 21:50:03 +0100 Subject: [PATCH] chore: ignore inspector_port_collision test (#21923) Ref https://github.com/denoland/deno/issues/21912 --------- Co-authored-by: Matt Mastracci --- cli/tests/integration/inspector_tests.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/cli/tests/integration/inspector_tests.rs b/cli/tests/integration/inspector_tests.rs index 78bac74b2e..872f9e3d2d 100644 --- a/cli/tests/integration/inspector_tests.rs +++ b/cli/tests/integration/inspector_tests.rs @@ -425,8 +425,12 @@ async fn inspector_pause() { #[tokio::test] async fn inspector_port_collision() { // Skip this test on WSL, which allows multiple processes to listen on the - // same port, rather than making `bind()` fail with `EADDRINUSE`. - if cfg!(target_os = "linux") && std::env::var_os("WSL_DISTRO_NAME").is_some() + // same port, rather than making `bind()` fail with `EADDRINUSE`. We also + // skip this test on Windows because it will occasionally flake, possibly + // due to a similar issue. + if (cfg!(target_os = "linux") + && std::env::var_os("WSL_DISTRO_NAME").is_some()) + || cfg!(windows) { return; }