foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-21 23:04:45 -05:00
Code Issues Packages 1 Wiki Activity

fix(op_crate/web): fix atob to throw spec aligned DOMException (#8798)

Browse source
This commit is contained in:
gorogoroumaru 2021-01-11 07:15:32 +09:00 committed by GitHub
parent 1a6ce29f3d
commit b0821fe9ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
cli/tests/unit/text_encoding_test.ts
View file

@ -50,6 +50,21 @@ unitTest(function atobThrows2(): void {
assert(threw);
});
unitTest(function atobThrows3(): void {
let threw = false;
try {
atob("foobar!!");
} catch (e) {
if (
e instanceof DOMException &&
e.toString().startsWith("InvalidCharacterError:")
) {
threw = true;
}
}
assert(threw);
});
unitTest(function btoaFailed(): void {
const text = "你好";
assertThrows(() => {

2
op_crates/web/08_text_encoding.js
View file

@ -105,7 +105,7 @@
if (rem === 1 || /[^+/0-9A-Za-z]/.test(s)) {
throw new DOMException(
"The string to be decoded is not correctly encoded",
"DataDecodeError",
"InvalidCharacterError",
);
}