From b1e5ad7eca8a1c6e38bb326daee9775b41687cf9 Mon Sep 17 00:00:00 2001 From: Yoshiya Hinosawa Date: Tue, 30 Jul 2019 16:39:32 +0900 Subject: [PATCH] enable test of aborted conn on windows (denoland/deno_std#549) Original: https://github.com/denoland/deno_std/commit/28ae08b4244cda59379e25b523c3490edbaa7ce2 --- http/server_test.ts | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/http/server_test.ts b/http/server_test.ts index da1a08dc02..9768ccdf4b 100644 --- a/http/server_test.ts +++ b/http/server_test.ts @@ -461,10 +461,6 @@ test({ test({ name: "[http] destroyed connection", async fn(): Promise { - // TODO: don't skip on windows when process.kill is implemented on windows. - if (Deno.build.os === "win") { - return; - } // Runs a simple server as another process const p = Deno.run({ args: [Deno.execPath, "http/testdata/simple_server.ts", "--allow-net"], @@ -477,11 +473,13 @@ test({ assert(s !== Deno.EOF && s.includes("server listening")); let serverIsRunning = true; - p.status().then( - (): void => { - serverIsRunning = false; - } - ); + p.status() + .then( + (): void => { + serverIsRunning = false; + } + ) + .catch((_): void => {}); // Ignores the error when closing the process. await delay(100); @@ -496,7 +494,7 @@ test({ assert(serverIsRunning); } finally { // Stops the sever. - p.kill(Deno.Signal.SIGINT); + p.close(); } } });