foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-29 16:30:56 -05:00
Code Issues Packages 1 Wiki Activity

fix: check if BroadcastChannel is open before sending (#17366)

Browse source 
Fixes #16978
This commit is contained in:
Leo Kettmeir 2023-01-12 13:43:36 +01:00 committed by David Sherret
parent 658fac6e86
commit b851b3ab74
2 changed files with 12 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
cli/tests/unit/broadcast_channel_test.ts
View file

@ -2,7 +2,7 @@
import { assertEquals } from "../../../test_util/std/testing/asserts.ts"; import { assertEquals } from "../../../test_util/std/testing/asserts.ts";
import { deferred } from "../../../test_util/std/async/deferred.ts"; import { deferred } from "../../../test_util/std/async/deferred.ts";
Deno.test("broadcastchannel worker", async () => { Deno.test("BroadcastChannel worker", async () => {
const intercom = new BroadcastChannel("intercom"); const intercom = new BroadcastChannel("intercom");
let count = 0; let count = 0;
@ -27,3 +27,9 @@ Deno.test("broadcastchannel worker", async () => {
await promise; await promise;
}); });
Deno.test("BroadcastChannel immediate close after post", () => {
const bc = new BroadcastChannel("internal_notification");
bc.postMessage("New listening connected!");
bc.close();
});

6
ext/broadcast_channel/01_broadcast_channel.js
View file

@ -122,7 +122,11 @@
dispatch(this, this[_name], new Uint8Array(data)); dispatch(this, this[_name], new Uint8Array(data));
// Send to listeners in other VMs. // Send to listeners in other VMs.
defer(() => core.opAsync("op_broadcast_send", rid, this[_name], data)); defer(() => {
if (!this[_closed]) {
core.opAsync("op_broadcast_send", rid, this[_name], data);
}
});
} }
close() { close() {