From b9b4b0dd672ba73b81ad9cbc381511b311a5aae0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bartek=20Iwa=C5=84czuk?= Date: Tue, 3 Sep 2024 10:11:41 +0100 Subject: [PATCH] feat: hide several --unstable-* flags (#25378) This commit hides following unstable flags: - `--unstable-ffi` (the API is now stable) - `--unstable-webgpu` (this API is now stable) - `--unstable-fs` (no more unstable APIs) - `--unstable-byonm` (BYONM is on by default) The flags are still parseable, but they are not used. Concrete cleanup will be done in a follow up PR. --- cli/args/flags.rs | 6 ------ runtime/lib.rs | 6 +++--- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/cli/args/flags.rs b/cli/args/flags.rs index 5470be9764..98db40a1e8 100644 --- a/cli/args/flags.rs +++ b/cli/args/flags.rs @@ -3848,15 +3848,9 @@ impl Iterator for UnstableArgsIter { } else if self.idx == 2 { Arg::new("unstable-byonm") .long("unstable-byonm") - .help("Enable unstable 'bring your own node_modules' feature") .value_parser(FalseyValueParser::new()) .action(ArgAction::SetTrue) .hide(true) - .long_help(match self.cfg { - UnstableArgsConfig::None => None, - UnstableArgsConfig::ResolutionOnly - | UnstableArgsConfig::ResolutionAndRuntime => Some("true"), - }) .help_heading(UNSTABLE_HEADING) } else if self.idx == 3 { Arg::new("unstable-sloppy-imports") diff --git a/runtime/lib.rs b/runtime/lib.rs index 083acf6572..daa55f773f 100644 --- a/runtime/lib.rs +++ b/runtime/lib.rs @@ -72,13 +72,13 @@ pub static UNSTABLE_GRANULAR_FLAGS: &[UnstableGranularFlag] = &[ UnstableGranularFlag { name: deno_ffi::UNSTABLE_FEATURE_NAME, help_text: "Enable unstable FFI APIs", - show_in_help: true, + show_in_help: false, id: 3, }, UnstableGranularFlag { name: deno_fs::UNSTABLE_FEATURE_NAME, help_text: "Enable unstable file system APIs", - show_in_help: true, + show_in_help: false, id: 4, }, UnstableGranularFlag { @@ -123,7 +123,7 @@ pub static UNSTABLE_GRANULAR_FLAGS: &[UnstableGranularFlag] = &[ UnstableGranularFlag { name: deno_webgpu::UNSTABLE_FEATURE_NAME, help_text: "Enable unstable `WebGPU` API", - show_in_help: true, + show_in_help: false, id: 11, }, UnstableGranularFlag {