foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-11-21 15:04:11 -05:00
Code Issues Packages 1 Wiki Activity

fix: don't include extensionless files in file collection for lint & fmt by default (#25721)

Browse source 
When using the `ext` flag, it will still attempt formatting them with
the provided extension
This commit is contained in:
Leo Kettmeir 2024-09-19 02:25:48 -07:00 committed by GitHub
parent 68065351df
commit bb45446fa7
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
cli/tools/fmt.rs
View file

@ -221,10 +221,8 @@ fn collect_fmt_files(
files: FilePatterns, files: FilePatterns,
) -> Result<Vec<PathBuf>, AnyError> { ) -> Result<Vec<PathBuf>, AnyError> {
FileCollector::new(|e| { FileCollector::new(|e| {
cli_options.ext_flag().as_ref().is_some_and(|ext| { is_supported_ext_fmt(e.path)
is_supported_ext_fmt(Path::new(&format!("placeholder.{ext}"))) || (e.path.extension().is_none() && cli_options.ext_flag().is_some())
}) || is_supported_ext_fmt(e.path)
|| e.path.extension().is_none()
}) })
.ignore_git_folder() .ignore_git_folder()
.ignore_node_modules() .ignore_node_modules()

6
cli/tools/lint/mod.rs
View file

@ -430,10 +430,8 @@ fn collect_lint_files(
files: FilePatterns, files: FilePatterns,
) -> Result<Vec<PathBuf>, AnyError> { ) -> Result<Vec<PathBuf>, AnyError> {
FileCollector::new(|e| { FileCollector::new(|e| {
cli_options.ext_flag().as_ref().is_some_and(|ext| { is_script_ext(e.path)
is_script_ext(Path::new(&format!("placeholder.{ext}"))) || (e.path.extension().is_none() && cli_options.ext_flag().is_some())
}) || is_script_ext(e.path)
|| e.path.extension().is_none()
}) })
.ignore_git_folder() .ignore_git_folder()
.ignore_node_modules() .ignore_node_modules()

5
tests/specs/fmt/default_ts/__test__.jsonc
View file

@ -12,6 +12,11 @@
}, },
"extensionless": { "extensionless": {
"args": "fmt extensionless", "args": "fmt extensionless",
"output": "error: No target files found.\n",
"exitCode": 1
},
"extensionless_with_flag": {
"args": "fmt --ext=ts extensionless",
"output": "Checked 1 file\n" "output": "Checked 1 file\n"
} }
} }

5
tests/specs/lint/default_ts/__test__.jsonc
View file

@ -12,6 +12,11 @@
}, },
"extensionless": { "extensionless": {
"args": "lint extensionless", "args": "lint extensionless",
"output": "error: No target files found.\n",
"exitCode": 1
},
"extensionless_with_flag": {
"args": "lint --ext=ts extensionless",
"output": "Checked 1 file\n" "output": "Checked 1 file\n"
} }
} }