foster/denoland-deno
1
0
Fork 0
mirror of https://github.com/denoland/deno.git synced 2024-12-22 07:14:47 -05:00
Code Issues Packages 1 Wiki Activity

fix(cli): improve logging on failed named pipe (#22726)

Browse source
This commit is contained in:
Matt Mastracci 2024-03-05 19:17:46 -07:00 committed by GitHub
parent ace25161c7
commit bebbb61eea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 12 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
ext/io/winpipe.rs
View file

@ -81,7 +81,10 @@ fn create_named_pipe_inner() -> io::Result<(RawHandle, RawHandle)> {
// This should not happen, so we would like to get some better diagnostics here. // This should not happen, so we would like to get some better diagnostics here.
// SAFETY: Printing last error for diagnostics // SAFETY: Printing last error for diagnostics
unsafe { unsafe {
eprintln!("*** Unexpected server pipe failure: {:x}", GetLastError()); eprintln!(
"*** Unexpected server pipe failure '{pipe_name:?}': {:x}",
GetLastError()
);
} }
return Err(io::Error::last_os_error()); return Err(io::Error::last_os_error());
} }
@ -110,13 +113,19 @@ fn create_named_pipe_inner() -> io::Result<(RawHandle, RawHandle)> {
|| error == winapi::shared::winerror::ERROR_PATH_NOT_FOUND || error == winapi::shared::winerror::ERROR_PATH_NOT_FOUND
{ {
// Exponential backoff, but don't sleep longer than 10ms // Exponential backoff, but don't sleep longer than 10ms
eprintln!("*** Unexpected client pipe not found failure: {:x}", error); eprintln!(
"*** Unexpected client pipe not found failure '{pipe_name:?}': {:x}",
error
);
std::thread::sleep(Duration::from_millis(10.min(2_u64.pow(i) + 1))); std::thread::sleep(Duration::from_millis(10.min(2_u64.pow(i) + 1)));
continue; continue;
} }
// This should not happen, so we would like to get some better diagnostics here. // This should not happen, so we would like to get some better diagnostics here.
eprintln!("*** Unexpected client pipe failure: {:x}", error); eprintln!(
"*** Unexpected client pipe failure '{pipe_name:?}': {:x}",
error
);
let err = io::Error::last_os_error(); let err = io::Error::last_os_error();
// SAFETY: Close the handles if we failed // SAFETY: Close the handles if we failed
unsafe { unsafe {